[PATCH 0/1] Fixes issue with Get Inkey variable timeout

[PATCH 0/1] Fixes issue with Get Inkey variable timeout

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

Hi,

 As per the ETSI TS 102 384 specification 27.22.4.2.8 section, duration
data object needs to be sent as part of the Get Inkey terminal response
for "No response from user" result.

Regards,
Jeevaka

Jeevaka Badrappan (1):
  stk: fix issue with Get Inkey variable timeout

 src/stk.c |   28 ++++++++++++++++++++++++++--
 1 files changed, 26 insertions(+), 2 deletions(-)

[PATCH 1/1] stk: fix issue with Get Inkey variable timeout

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

---
 src/stk.c |   28 ++++++++++++++++++++++++++--
 1 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/src/stk.c b/src/stk.c
index e933e4e..68b6240 100644
--- a/src/stk.c
+++ b/src/stk.c
@@ -1396,7 +1396,19 @@ static void request_confirmation_cb(enum stk_agent_result result,
 		break;
 
 	case STK_AGENT_RESULT_TIMEOUT:
-		send_simple_response(stk, STK_RESULT_TYPE_NO_RESPONSE);
+		memset(&rsp, 0, sizeof(rsp));
+
+		rsp.result.type = STK_RESULT_TYPE_NO_RESPONSE;
+
+		if (cmd->duration.interval) {
+			rsp.get_inkey.duration.unit = cmd->duration.unit;
+			set_get_inkey_duration(&rsp.get_inkey.duration,
+						&stk->get_inkey_start_ts);
+		}
+
+		if (stk_respond(stk, &rsp, stk_command_cb))
+			stk_command_cb(&error, stk);
+
 		break;
 
 	case STK_AGENT_RESULT_TERMINATE:
@@ -1439,7 +1451,19 @@ static void request_key_cb(enum stk_agent_result result, char *string,
 		break;
 
 	case STK_AGENT_RESULT_TIMEOUT:
-		send_simple_response(stk, STK_RESULT_TYPE_NO_RESPONSE);
+		memset(&rsp, 0, sizeof(rsp));
+
+		rsp.result.type = STK_RESULT_TYPE_NO_RESPONSE;
+
+		if (cmd->duration.interval) {
+			rsp.get_inkey.duration.unit = cmd->duration.unit;
+			set_get_inkey_duration(&rsp.get_inkey.duration,
+						&stk->get_inkey_start_ts);
+		}
+
+		if (stk_respond(stk, &rsp, stk_command_cb))
+			stk_command_cb(&error, stk);
+
 		break;
 
 	case STK_AGENT_RESULT_TERMINATE:
-- 
1.7.0.4

Re: [PATCH 1/1] stk: fix issue with Get Inkey variable timeout

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi Jeevaka,

On 03/16/2011 12:57 PM, Jeevaka Badrappan wrote:
> ---
>  src/stk.c |   28 ++++++++++++++++++++++++++--
>  1 files changed, 26 insertions(+), 2 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis