[PATCH] PPP: Switch ringbuffer.c to g_slice allocator

[PATCH] PPP: Switch ringbuffer.c to g_slice allocator

[Patrick Porlan]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

This should allow for more efficient handling of equally sized
buffers, in terms of alignment and recycling.
---
 gatchat/ringbuffer.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gatchat/ringbuffer.c b/gatchat/ringbuffer.c
index 27be3a8..775498c 100644
--- a/gatchat/ringbuffer.c
+++ b/gatchat/ringbuffer.c
@@ -51,11 +51,11 @@ struct ring_buffer *ring_buffer_new(unsigned int size)
 	if (real_size > MAX_SIZE)
 		return NULL;
 
-	buffer = g_try_new(struct ring_buffer, 1);
+	buffer = g_slice_new(struct ring_buffer);
 	if (buffer == NULL)
 		return NULL;
 
-	buffer->buffer = g_try_new(unsigned char, real_size);
+	buffer->buffer = g_slice_alloc(real_size);
 	if (buffer->buffer == NULL) {
 		g_free(buffer);
 		return NULL;
@@ -202,6 +202,6 @@ void ring_buffer_free(struct ring_buffer *buf)
 	if (buf == NULL)
 		return;
 
-	g_free(buf->buffer);
-	g_free(buf);
+	g_slice_free1(buf->size, buf->buffer);
+	g_slice_free1(sizeof(struct ring_buffer), buf);
 }
-- 
1.7.1

Re: [PATCH] PPP: Switch ringbuffer.c to g_slice allocator

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

Hi Patrick,

On 03/16/2011 04:24 AM, Patrick Porlan wrote:
> This should allow for more efficient handling of equally sized
> buffers, in terms of alignment and recycling.
> ---
>  gatchat/ringbuffer.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis