Re: [PATCH 01/12] dbus: add gnss interface definition

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Hi Jarko,

On 03/11/2011 06:22 AM, Jarko Poutiainen wrote:
> ---
>  include/dbus.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/dbus.h b/include/dbus.h
> index 19a138a..bf3e8a4 100644
> --- a/include/dbus.h
> +++ b/include/dbus.h
> @@ -56,6 +56,8 @@ extern "C" {
>  #define OFONO_STK_INTERFACE OFONO_SERVICE ".SimToolkit"
>  #define OFONO_SIM_APP_INTERFACE OFONO_SERVICE ".SimToolkitAgent"
>  #define OFONO_LOCATION_REPORTING_INTERFACE OFONO_SERVICE ".LocationReporting"
> +#define OFONO_AS_NAVIGATION_INTERFACE "org.ofono.AssistedSatelliteNavigation"

Please name this OFONO_GNSS_INTERFACE

> +#define OFONO_POSITIONING_REQUEST_INTERFACE "org.ofono.PositioningRequestAgent"

Please name this OFONO_GNSS_POSR_INTERFACE or
OFONO_GNSS_POSR_AGENT_INTERFACE

Or feel free to suggest a better name, but the current names are getting
too big

>  
>  /* CDMA Interfaces */
>  #define OFONO_CDMA_VOICECALL_MANAGER_INTERFACE "org.ofono.cdma.VoiceCallManager"

Regards,
-Denis