Re: [PATCH 07/12] gatchat: implementation for +CPOS send

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Hi Jarko,

On 03/11/2011 06:23 AM, Jarko Poutiainen wrote:
> ---
>  gatchat/gatchat.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c
> index 3fd564d..64f131d 100644
> --- a/gatchat/gatchat.c
> +++ b/gatchat/gatchat.c
> @@ -1468,6 +1468,19 @@ guint g_at_chat_send_pdu_listing(GAtChat *chat, const char *cmd,
>  					listing, func, user_data, notify);
>  }
>  
> +guint g_at_chat_send_and_expect_short_prompt(GAtChat *chat, const char *cmd,
> +			const char **prefix_list, GAtResultFunc func,
> +			gpointer user_data, GDestroyNotify notify)
> +{
> +	if(chat != NULL)
> +		chat->parent->syntax->set_hint(chat->parent->syntax,
> +					G_AT_SYNTAX_EXPECT_SHORT_PROMPT);

So unfortunately you can't do this.  GAtChat is a command queue and we
might be in the process of sending / receiving responses for multiple
commands that are ahead of this one.  So you can't really manipulate the
syntax directly here.  You have to do this only once the CPOSR has been
sent on the wire.

> +
> +	return at_chat_send_common(chat->parent, chat->group,
> +					cmd, prefix_list, FALSE, NULL,
> +					func, user_data, notify);
> +}
> +
>  gboolean g_at_chat_cancel(GAtChat *chat, guint id)
>  {
>  	/* We use id 0 for wakeup commands */

Regards,
-Denis