All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mirek Slugeň" <thunder.m@email.cz>
To: linux-dvb@linuxtv.org
Cc: linux-kernel@vger.kernel.org
Subject: Patch for broken radio in XC2k and XC3k tuners
Date: Sun, 20 Mar 2011 00:12:33 +0100	[thread overview]
Message-ID: <4D853861.7010206@email.cz> (raw)

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hi, I am very supprised that no one complains about broken radio support 
on devices with XC2k and XC3k tuner, it is broken since commit:

V4L/DVB: tuner-xc2028: fix tuning logic to solve a regression in Australia

from date 19.3.2010

BUG is present in current kernel stable version 2.6.38 and also olders 
like 2.6.37, fix is very trivial.

I tested this fix with Leadtek DTV1800H radio and it works great, before 
this fix I can listen so much of noise on tuned frequency (so something 
wrong with tuning).

Feel free to modify this patch :)

M. Slugen

[-- Attachment #2: kernel_xc2000_radio.diff --]
[-- Type: text/x-patch, Size: 422 bytes --]

--- linux-2.6.37.2.old/drivers/media/common/tuners/tuner-xc2028.c	2011-03-19 23:25:28.000000000 +0100
+++ linux-2.6.37.2/drivers/media/common/tuners/tuner-xc2028.c	2011-03-19 23:26:13.458252000 +0100
@@ -937,6 +937,8 @@
 		rc = send_seq(priv, {0x00, 0x00});
 
 		/* Analog modes require offset = 0 */
+	} else if (new_mode == T_RADIO) {
+		/* nop */
 	} else {
 		/*
 		 * Digital modes require an offset to adjust to the

WARNING: multiple messages have this Message-ID (diff)
From: "Mirek Slugeň" <thunder.m@email.cz>
To: linux-dvb@linuxtv.org
Cc: linux-kernel@vger.kernel.org
Subject: [linux-dvb] Patch for broken radio in XC2k and XC3k tuners
Date: Sun, 20 Mar 2011 00:12:33 +0100	[thread overview]
Message-ID: <4D853861.7010206@email.cz> (raw)

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hi, I am very supprised that no one complains about broken radio support 
on devices with XC2k and XC3k tuner, it is broken since commit:

V4L/DVB: tuner-xc2028: fix tuning logic to solve a regression in Australia

from date 19.3.2010

BUG is present in current kernel stable version 2.6.38 and also olders 
like 2.6.37, fix is very trivial.

I tested this fix with Leadtek DTV1800H radio and it works great, before 
this fix I can listen so much of noise on tuned frequency (so something 
wrong with tuning).

Feel free to modify this patch :)

M. Slugen

[-- Attachment #2: kernel_xc2000_radio.diff --]
[-- Type: text/x-patch, Size: 422 bytes --]

--- linux-2.6.37.2.old/drivers/media/common/tuners/tuner-xc2028.c	2011-03-19 23:25:28.000000000 +0100
+++ linux-2.6.37.2/drivers/media/common/tuners/tuner-xc2028.c	2011-03-19 23:26:13.458252000 +0100
@@ -937,6 +937,8 @@
 		rc = send_seq(priv, {0x00, 0x00});
 
 		/* Analog modes require offset = 0 */
+	} else if (new_mode == T_RADIO) {
+		/* nop */
 	} else {
 		/*
 		 * Digital modes require an offset to adjust to the

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

             reply	other threads:[~2011-03-19 23:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-19 23:12 Mirek Slugeň [this message]
2011-03-19 23:12 ` [linux-dvb] Patch for broken radio in XC2k and XC3k tuners Mirek Slugeň

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D853861.7010206@email.cz \
    --to=thunder.m@email.cz \
    --cc=linux-dvb@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.