[Qemu-devel] Query: gdbstub software breakpoint removal

[Qemu-devel] Query: gdbstub software breakpoint removal

[Bhushan Bharat-R65777]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hi All,

I can see that the software breakpoint queue is cleared in kvm_remove_breakpoint() in kvm-all.c.  I.e QTAILQ_REMOVE(&current_env->kvm_state->kvm_sw_breakpoints, bp, entry); is called when the breakpoint is cleared.

While the queue is not cleared on kvm_remove_all_breakpoints();
Is there any specific reason for that?


Thanks
-Bharat


[-- Attachment #2: Type: text/html, Size: 2296 bytes --]

[Qemu-devel] Re: Query: gdbstub software breakpoint removal

[Jan Kiszka]

On 2011-03-21 12:01, Bhushan Bharat-R65777 wrote:
> Hi All,
> 
> I can see that the software breakpoint queue is cleared in kvm_remove_breakpoint() in kvm-all.c.  I.e QTAILQ_REMOVE(&current_env->kvm_state->kvm_sw_breakpoints, bp, entry); is called when the breakpoint is cleared.
> 
> While the queue is not cleared on kvm_remove_all_breakpoints();
> Is there any specific reason for that?

Hmm, no particular reason that I recall. This rather looks like a very
old leak. Patch welcome.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

[Qemu-devel] RE: Query: gdbstub software breakpoint removal

[Bhushan Bharat-R65777]

Hi Jan,

I will send a patch.

Thanks
-Bharat

> -----Original Message-----
> From: Jan Kiszka [mailto:jan.kiszka@siemens.com]
> Sent: Monday, March 21, 2011 5:04 PM
> To: Bhushan Bharat-R65777
> Cc: qemu-devel@nongnu.org
> Subject: Re: Query: gdbstub software breakpoint removal
> 
> On 2011-03-21 12:01, Bhushan Bharat-R65777 wrote:
> > Hi All,
> >
> > I can see that the software breakpoint queue is cleared in
> kvm_remove_breakpoint() in kvm-all.c.  I.e QTAILQ_REMOVE(&current_env-
> >kvm_state->kvm_sw_breakpoints, bp, entry); is called when the breakpoint
> is cleared.
> >
> > While the queue is not cleared on kvm_remove_all_breakpoints(); Is
> > there any specific reason for that?
> 
> Hmm, no particular reason that I recall. This rather looks like a very
> old leak. Patch welcome.
> 
> Jan
> 
> --
> Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence
> Center Embedded Linux