* [PATCH 7/7] ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue
@ 2011-03-22 8:26 Lydia Wang
2011-03-22 8:33 ` Jaroslav Kysela
0 siblings, 1 reply; 3+ messages in thread
From: Lydia Wang @ 2011-03-22 8:26 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, HaraldWelte, lydiawang
From: Lydia Wang <lydiawang@viatech.com.cn>
Subject: ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue.
Since VT1708 didn't support the control of getting connection number,
building of headphone control will fail in via_hp_build() function.
Signed-off-by: Lydia Wang <lydiawang@viatech.com.cn>
---
sound/pci/hda/patch_via.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -1266,9 +1266,12 @@
break;
}
- nums = snd_hda_get_connections(codec, nid, conn, HDA_MAX_CONNECTIONS);
- if (nums <= 1)
- return 0;
+ if (spec->codec_type != VT1708) {
+ nums = snd_hda_get_connections(codec, nid,
+ conn, HDA_MAX_CONNECTIONS);
+ if (nums <= 1)
+ return 0;
+ }
knew = via_clone_control(spec, &via_hp_mixer[0]);
if (knew == NULL)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 7/7] ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue
2011-03-22 8:26 [PATCH 7/7] ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue Lydia Wang
@ 2011-03-22 8:33 ` Jaroslav Kysela
2011-03-22 9:08 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Jaroslav Kysela @ 2011-03-22 8:33 UTC (permalink / raw)
To: Lydia Wang; +Cc: tiwai, alsa-devel, HaraldWelte
On Tue, 22 Mar 2011, Lydia Wang wrote:
> From: Lydia Wang <lydiawang@viatech.com.cn>
> Subject: ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue.
>
> Since VT1708 didn't support the control of getting connection number,
> building of headphone control will fail in via_hp_build() function.
I would move the declaration of 'nums' variable to the if {} section here.
Jaroslav
-----
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 7/7] ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue
2011-03-22 8:33 ` Jaroslav Kysela
@ 2011-03-22 9:08 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2011-03-22 9:08 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel, HaraldWelte, Lydia Wang
At Tue, 22 Mar 2011 09:33:08 +0100 (CET),
Jaroslav Kysela wrote:
>
> On Tue, 22 Mar 2011, Lydia Wang wrote:
>
> > From: Lydia Wang <lydiawang@viatech.com.cn>
> > Subject: ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue.
> >
> > Since VT1708 didn't support the control of getting connection number,
> > building of headphone control will fail in via_hp_build() function.
>
> I would move the declaration of 'nums' variable to the if {} section here.
But it would double the patch size ;)
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-22 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-22 8:26 [PATCH 7/7] ALSA: VIA HDA: Fix VT1708 can't build up Headphone control issue Lydia Wang
2011-03-22 8:33 ` Jaroslav Kysela
2011-03-22 9:08 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.