From: Avi Kivity <avi@redhat.com>
To: Ulrich Obergfell <uobergfe@redhat.com>
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
gcosta@redhat.com, Anthony Liguori <anthony@codemonkey.ws>,
aliguori@us.ibm.com, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 0/3] alleviate time drift with HPET periodic timers
Date: Tue, 22 Mar 2011 12:07:18 +0200 [thread overview]
Message-ID: <4D8874D6.9070704@redhat.com> (raw)
In-Reply-To: <1270297532.421733.1300463647982.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
On 03/18/2011 05:54 PM, Ulrich Obergfell wrote:
> Please review and please comment.
Some procedural remarks:
- put all patches in the same thread. 'git send-email' can do that
automatically for you. This really helps reviewers, at least with some
email readers
- give individual patches meaningful subjects (not 'alleviate time drift
with HPET periodic timers' for all patches + subject letter)
- reduce the amount of ifdefs in your patches
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Ulrich Obergfell <uobergfe@redhat.com>
Cc: aliguori@us.ibm.com, kvm <kvm@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, gcosta@redhat.com
Subject: [Qemu-devel] Re: [PATCH 0/3] alleviate time drift with HPET periodic timers
Date: Tue, 22 Mar 2011 12:07:18 +0200 [thread overview]
Message-ID: <4D8874D6.9070704@redhat.com> (raw)
In-Reply-To: <1270297532.421733.1300463647982.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
On 03/18/2011 05:54 PM, Ulrich Obergfell wrote:
> Please review and please comment.
Some procedural remarks:
- put all patches in the same thread. 'git send-email' can do that
automatically for you. This really helps reviewers, at least with some
email readers
- give individual patches meaningful subjects (not 'alleviate time drift
with HPET periodic timers' for all patches + subject letter)
- reduce the amount of ifdefs in your patches
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-03-22 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12536436.420561.1300460231798.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2011-03-18 15:54 ` [PATCH 0/3] alleviate time drift with HPET periodic timers Ulrich Obergfell
2011-03-18 15:54 ` [Qemu-devel] " Ulrich Obergfell
2011-03-22 10:07 ` Avi Kivity [this message]
2011-03-22 10:07 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8874D6.9070704@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=gcosta@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.