From: Holger Hans Peter Freyther <holger@freyther.de>
To: netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org
Subject: [PATCH] sctp: Make some local functions static
Date: Wed, 23 Mar 2011 10:48:07 +0000 [thread overview]
Message-ID: <4D89CFE7.4050907@freyther.de> (raw)
In-Reply-To: <4D35798E.3010800@selfish.org>
sparse proposed to mark these functions as static as they are
only accessed locally. This patch is doing that.
Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>
Acked-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/probe.c | 10 +++++-----
net/sctp/sm_make_chunk.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/sctp/probe.c b/net/sctp/probe.c
index bc6cd75..4616548 100644
--- a/net/sctp/probe.c
+++ b/net/sctp/probe.c
@@ -122,11 +122,11 @@ static const struct file_operations sctpprobe_fops = {
.llseek = noop_llseek,
};
-sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
- const struct sctp_association *asoc,
- const sctp_subtype_t type,
- void *arg,
- sctp_cmd_seq_t *commands)
+static sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
+ const struct sctp_association *asoc,
+ const sctp_subtype_t type,
+ void *arg,
+ sctp_cmd_seq_t *commands)
{
struct sctp_transport *sp;
static __u32 lcwnd = 0;
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index de98665..a8c0798 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -132,8 +132,8 @@ void sctp_init_cause(struct sctp_chunk *chunk, __be16
cause_code,
* abort chunk. Differs from sctp_init_cause in that it won't oops
* if there isn't enough space in the op error chunk
*/
-int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
- size_t paylen)
+static int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
+ size_t paylen)
{
sctp_errhdr_t err;
__u16 len;
--
1.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Holger Hans Peter Freyther <holger@freyther.de>
To: netdev@vger.kernel.org
Cc: linux-sctp@vger.kernel.org
Subject: [PATCH] sctp: Make some local functions static
Date: Wed, 23 Mar 2011 11:48:07 +0100 [thread overview]
Message-ID: <4D89CFE7.4050907@freyther.de> (raw)
sparse proposed to mark these functions as static as they are
only accessed locally. This patch is doing that.
Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>
Acked-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/probe.c | 10 +++++-----
net/sctp/sm_make_chunk.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/sctp/probe.c b/net/sctp/probe.c
index bc6cd75..4616548 100644
--- a/net/sctp/probe.c
+++ b/net/sctp/probe.c
@@ -122,11 +122,11 @@ static const struct file_operations sctpprobe_fops = {
.llseek = noop_llseek,
};
-sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
- const struct sctp_association *asoc,
- const sctp_subtype_t type,
- void *arg,
- sctp_cmd_seq_t *commands)
+static sctp_disposition_t jsctp_sf_eat_sack(const struct sctp_endpoint *ep,
+ const struct sctp_association *asoc,
+ const sctp_subtype_t type,
+ void *arg,
+ sctp_cmd_seq_t *commands)
{
struct sctp_transport *sp;
static __u32 lcwnd = 0;
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index de98665..a8c0798 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -132,8 +132,8 @@ void sctp_init_cause(struct sctp_chunk *chunk, __be16
cause_code,
* abort chunk. Differs from sctp_init_cause in that it won't oops
* if there isn't enough space in the op error chunk
*/
-int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
- size_t paylen)
+static int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
+ size_t paylen)
{
sctp_errhdr_t err;
__u16 len;
--
1.7.4
next prev parent reply other threads:[~2011-03-23 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 11:29 [PATCH] sctp: Make some local functions static Holger Freyther
2011-01-19 7:23 ` Wei Yongjun
2011-03-23 10:48 ` Holger Hans Peter Freyther [this message]
2011-03-23 10:48 ` Holger Hans Peter Freyther
2011-03-28 1:16 ` David Miller
2011-03-28 1:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D89CFE7.4050907@freyther.de \
--to=holger@freyther.de \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.