terminal_input=at_keyboard not working

terminal_input=at_keyboard not working

[Frédéric Boiteux]

	Hello,

  I've installed the 1.99rc1 version of Grub2 on my Debian system to
use the new keyboard layout system. I've read that to work, I have to
set up following configuration :

* in /etc/default/grub :

GRUB_TERMINAL_INPUT=at_keyboard

* in /etc/grub.d/40_custom :

insmod keylayouts
keymap /boot/grub/bepo.gkb


with the Grub's keymap 'bepo.gkb' done with :
ckbcomp fr bepo |grub-mklayout -v -o /boot/grub/bepo.gkb


  I've tested this config on one laptop with success, but on another, a
HP 6730b, I found that 'GRUB_TERMINAL_INPUT=at_keyboard' does freeze
the system, and I've to restart the system from a USB key to recover
the grub system (I didn't find a way to tell Grub2 to ignore its
grub.cfg file).

  Do you know a possible cause for my problem, and some possible
solution ?

	Thanks,
		Fred.

Re: terminal_input=at_keyboard not working

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On 04.02.2011 15:18, Frédéric Boiteux wrote:
> 	Hello,
>
>   I've installed the 1.99rc1 version of Grub2 on my Debian system to
> use the new keyboard layout system. I've read that to work, I have to
> set up following configuration :
>
> * in /etc/default/grub :
>
> GRUB_TERMINAL_INPUT=at_keyboard
>
> * in /etc/grub.d/40_custom :
>
> insmod keylayouts
> keymap /boot/grub/bepo.gkb
>
>
> with the Grub's keymap 'bepo.gkb' done with :
> ckbcomp fr bepo |grub-mklayout -v -o /boot/grub/bepo.gkb
>
>
>   I've tested this config on one laptop with success, but on another, a
> HP 6730b, I found that 'GRUB_TERMINAL_INPUT=at_keyboard' does freeze
> the system, and I've to restart the system from a USB key to recover
> the grub system (I didn't find a way to tell Grub2 to ignore its
> grub.cfg file).
>
>   Do you know a possible cause for my problem, and some possible
> solution ?
>   
Could you try this patch:
=== modified file 'grub-core/term/at_keyboard.c'
--- grub-core/term/at_keyboard.c    2011-01-08 00:45:57 +0000
+++ grub-core/term/at_keyboard.c    2011-03-23 19:33:57 +0000
@@ -330,6 +330,11 @@
       return;
     }
 
+#if !(defined (GRUB_MACHINE_MIPS_YEELOONG) || defined (GRUB_MACHINE_QEMU))
+  current_set = 1;
+  return;
+#endif
+
   grub_keyboard_controller_write (grub_keyboard_controller_orig
                   & ~KEYBOARD_AT_TRANSLATE);
 


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

Re: terminal_input=at_keyboard not working

[Frédéric Boiteux]

Le Wed, 23 Mar 2011 20:34:36 +0100,
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> a > On 04.02.2011 15:18, Frédéric Boiteux wrote:
> > 	Hello,
> >
> >   I've installed the 1.99rc1 version of Grub2 on my Debian system to
> > use the new keyboard layout system. I've read that to work, I have
> > to set up following configuration :
> >
> > * in /etc/default/grub :
> >
> > GRUB_TERMINAL_INPUT=at_keyboard
> >
> > * in /etc/grub.d/40_custom :
> >
> > insmod keylayouts
> > keymap /boot/grub/bepo.gkb
> >
> >
> > with the Grub's keymap 'bepo.gkb' done with :
> > ckbcomp fr bepo |grub-mklayout -v -o /boot/grub/bepo.gkb
> >
> >
> >   I've tested this config on one laptop with success, but on
> > another, a HP 6730b, I found that 'GRUB_TERMINAL_INPUT=at_keyboard'
> > does freeze the system, and I've to restart the system from a USB
> > key to recover the grub system (I didn't find a way to tell Grub2
> > to ignore its grub.cfg file).
> >
> >   Do you know a possible cause for my problem, and some possible
> > 
> Could you try this patch:
> === modified file 'grub-core/term/at_keyboard.c'
> --- grub-core/term/at_keyboard.c    2011-01-08 00:45:57 +0000
> +++ grub-core/term/at_keyboard.c    2011-03-23 19:33:57 +0000
> @@ -330,6 +330,11 @@
>        return;
>      }
>  
> +#if !(defined (GRUB_MACHINE_MIPS_YEELOONG) || defined
> (GRUB_MACHINE_QEMU))
> +  current_set = 1;
> +  return;
> +#endif
> +
>    grub_keyboard_controller_write (grub_keyboard_controller_orig
>                    & ~KEYBOARD_AT_TRANSLATE);
>  
> 
> 


-- 
Frédéric Boiteux  à  Calistel
INOVALLEE - 82, allée Galilée - 38330  Montbonnot - France
Téléphone: +33 (0) 4 76 52 61 16
Clé GPG: 4096R/624C8AB4

Re: terminal_input=at_keyboard not working

[Frédéric Boiteux]

Le Wed, 23 Mar 2011 20:34:36 +0100,
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> a écrit :
 
> Could you try this patch:
> === modified file 'grub-core/term/at_keyboard.c'
> --- grub-core/term/at_keyboard.c    2011-01-08 00:45:57 +0000
> +++ grub-core/term/at_keyboard.c    2011-03-23 19:33:57 +0000
> @@ -330,6 +330,11 @@
>        return;
>      }
>  
> +#if !(defined (GRUB_MACHINE_MIPS_YEELOONG) || defined
> (GRUB_MACHINE_QEMU))
> +  current_set = 1;
> +  return;
> +#endif
> +
>    grub_keyboard_controller_write (grub_keyboard_controller_orig
>                    & ~KEYBOARD_AT_TRANSLATE);


	Hello Vladimir,

  I've tested your patch (adapted a little bit) on latest Debian's
grub-pc package (1.99-rc1-6), and it worked well, my HP laptop doesn't
freeze at Grub boot, and I can now use my custom keyboard layout !

    Thanks,
	Fred.

Re: terminal_input=at_keyboard not working

[Vladimir 'φ-coder/phcoder' Serbinenko]

> 	Hello Vladimir,
>
>   I've tested your patch (adapted a little bit) on latest Debian's
> grub-pc package (1.99-rc1-6), and it worked well, my HP laptop doesn't
> freeze at Grub boot, and I can now use my custom keyboard layout !
>
>   
Committed upstream. Thanks for testing



-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko