All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] voicecall: fix voicecalls_release_queue
@ 2011-03-24 17:43 =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
  2011-03-24 18:30 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis @ 2011-03-24 17:43 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

voicecalls_release_queue uses struct ofono_call instead of
struct voicecall (which is used in "calls" list parameter and
function voicecalls_release_next)
---
 src/voicecall.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index 4932ffa..b1d5586 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -1070,7 +1070,7 @@ static void voicecalls_emit_call_added(struct ofono_voicecall *vc,
 static void voicecalls_release_queue(struct ofono_voicecall *vc, GSList *calls)
 {
 	GSList *l;
-	struct ofono_call *call;
+	struct voicecall *call;
 
 	g_slist_free(vc->release_list);
 	vc->release_list = NULL;
@@ -1078,7 +1078,7 @@ static void voicecalls_release_queue(struct ofono_voicecall *vc, GSList *calls)
 	for (l = calls; l; l = l->next) {
 		call = l->data;
 
-		if (call->status == CALL_STATUS_WAITING)
+		if (call->call->status == CALL_STATUS_WAITING)
 			continue;
 
 		vc->release_list = g_slist_prepend(vc->release_list, l->data);
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] voicecall: fix voicecalls_release_queue
  2011-03-24 17:43 [PATCH] voicecall: fix voicecalls_release_queue =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
@ 2011-03-24 18:30 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2011-03-24 18:30 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hi Frédéric,

On 03/24/2011 12:43 PM, Frédéric Danis wrote:
> voicecalls_release_queue uses struct ofono_call instead of
> struct voicecall (which is used in "calls" list parameter and
> function voicecalls_release_next)
> ---
>  src/voicecall.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 

Good spot, patch has been applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-24 18:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24 17:43 [PATCH] voicecall: fix voicecalls_release_queue =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-03-24 18:30 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.