All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Chris Mason <chris.mason@oracle.com>
Subject: Re: [GIT PULL] Core block IO bits for 2.6.39 - early Oops
Date: Fri, 25 Mar 2011 17:01:09 +0100	[thread overview]
Message-ID: <4D8CBC45.7020002@fusionio.com> (raw)
In-Reply-To: <20110325155821.GA1661@gentoo.trippels.de>

On 2011-03-25 16:58, Markus Trippelsdorf wrote:
> On 2011.03.25 at 16:51 +0100, Jens Axboe wrote:
>> On 2011-03-25 15:28, Markus Trippelsdorf wrote:
>>> On 2011.03.25 at 15:20 +0100, Jens Axboe wrote:
>>>> On 2011-03-25 15:14, Markus Trippelsdorf wrote:
>>>>> On 2011.03.25 at 15:10 +0100, Jens Axboe wrote:
>>>>>> On 2011-03-25 14:09, Markus Trippelsdorf wrote:
>>>>>>> On 2011.03.25 at 13:44 +0100, Jens Axboe wrote:
>>>>>>>> On 2011-03-25 10:57, Markus Trippelsdorf wrote:
>>>>>>>>>
>>>>>>>>> Reverting it solves all problems here.
>>>>>>>>
>>>>>>>> Can you try this one?
>>>>>>>
>>>>>>> This one doesn't help; I still get the same BUG.
>>>>>>>
>>>>>>> BTW if you're having trouble reproducing this, here is the only non
>>>>>>> stock xfs option that I use on the affected partitions:
>>>>>>>
>>>>>>> noatime,logbsize=262144
>>>>>>
>>>>>> This?
>>>>>
>>>>> No.
>>>>
>>>> Lets expand the scope a bit, this one?
>>>
>>> No. And setting CONFIG_PREEMPT_NONE also doesn't help.
>>>
>>
>> Does this work? I'm actually relieved that the preempt was a red
>> herring. I had earlier convinced myself that it was all safe without
>> that mucking around with preempt counts.
> 
> Finally: YES. 
> Many thanks Jens.

Awesome. And thanks goes to you for doing tons of testing and having a
rapid turn-around time, and to Sergey for finding the right commit that
allowed a genuine fix.

I'll prepare a pull for Linus immediately.

-- 
Jens Axboe


  reply	other threads:[~2011-03-25 16:01 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 13:43 [GIT PULL] Core block IO bits for 2.6.39 Jens Axboe
2011-03-24 18:30 ` [GIT PULL] Core block IO bits for 2.6.39 - early Oops Markus Trippelsdorf
2011-03-24 18:36   ` Jens Axboe
2011-03-24 18:47     ` Markus Trippelsdorf
2011-03-24 18:51     ` Jens Axboe
2011-03-24 18:54       ` Markus Trippelsdorf
2011-03-24 18:58         ` Jens Axboe
2011-03-24 19:34           ` Markus Trippelsdorf
2011-03-24 19:36             ` Jens Axboe
2011-03-24 19:45               ` Markus Trippelsdorf
2011-03-24 19:57                 ` Jens Axboe
2011-03-24 20:06                   ` Markus Trippelsdorf
2011-03-24 21:01                     ` Jens Axboe
2011-03-24 21:41                       ` Markus Trippelsdorf
2011-03-25  7:23                         ` Jens Axboe
2011-03-25  8:37                           ` Markus Trippelsdorf
2011-03-25  8:44                             ` Jens Axboe
2011-03-25  9:27                               ` Markus Trippelsdorf
2011-03-25  9:57                               ` Markus Trippelsdorf
2011-03-25 10:11                                 ` Jens Axboe
2011-03-25 12:44                                 ` Jens Axboe
2011-03-25 13:09                                   ` Markus Trippelsdorf
2011-03-25 14:10                                     ` Jens Axboe
2011-03-25 14:14                                       ` Markus Trippelsdorf
2011-03-25 14:18                                         ` Chris Mason
2011-03-25 14:19                                           ` Chris Mason
2011-03-25 14:24                                             ` Markus Trippelsdorf
2011-03-25 14:20                                         ` Jens Axboe
2011-03-25 14:28                                           ` Markus Trippelsdorf
2011-03-25 15:51                                             ` Jens Axboe
2011-03-25 15:58                                               ` Markus Trippelsdorf
2011-03-25 16:01                                                 ` Jens Axboe [this message]
2011-03-24 22:06                       ` Markus Trippelsdorf
2011-03-25  4:41             ` Dave Chinner
2011-03-25  7:26               ` Jens Axboe
2011-03-25 11:59               ` Theodore Tso
2011-03-25 12:14                 ` Jens Axboe
2011-03-25 12:33                   ` Ted Ts'o
2011-03-25 12:43                     ` Jens Axboe
2011-03-25 13:01               ` Chris Mason
2011-03-25 21:35 ` [GIT PULL] Core block IO bits for 2.6.39 Geert Uytterhoeven
2011-03-26  6:29   ` Jens Axboe
2011-03-26  7:21     ` Geert Uytterhoeven
2011-03-26  8:25       ` Jens Axboe
2011-03-26  8:34         ` Geert Uytterhoeven
2011-03-26  9:26           ` Jens Axboe
2011-03-26 16:48     ` Linus Torvalds
2011-03-26 16:53       ` Jens Axboe
2011-03-26 18:48         ` Jens Axboe
2011-03-27 13:21       ` Alan Cox
2011-03-27 11:49 ` Avi Kivity
2011-03-27 12:00   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8CBC45.7020002@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=chris.mason@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.