From: Jens Axboe <jaxboe-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
To: Ryusuke Konishi
<konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
Cc: linux-nilfs <linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] nilfs2: fix oops due to a bad aops initialization
Date: Wed, 30 Mar 2011 13:07:46 +0200 [thread overview]
Message-ID: <4D930F02.4070409@fusionio.com> (raw)
In-Reply-To: <20110330.132555.158630340.ryusuke-sG5X7nlA6pw@public.gmane.org>
On 2011-03-30 06:25, Ryusuke Konishi wrote:
> diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
> index 4d2a1ee..9d2dc6b 100644
> --- a/fs/nilfs2/page.c
> +++ b/fs/nilfs2/page.c
> @@ -495,12 +495,14 @@ unsigned nilfs_page_count_clean_buffers(struct page *page,
> void nilfs_mapping_init(struct address_space *mapping,
> struct backing_dev_info *bdi)
> {
> + static const struct address_space_operations empty_aops;
> +
> mapping->host = NULL;
> mapping->flags = 0;
> mapping_set_gfp_mask(mapping, GFP_NOFS);
> mapping->assoc_mapping = NULL;
> mapping->backing_dev_info = bdi;
> - mapping->a_ops = NULL;
> + mapping->a_ops = &empty_aops;
> }
Hmm wait, inode init should set the mapping aops to an empty type
already. Does the OOPS go away if you just remove the mapping->a_ops =
NULL assignment?
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <jaxboe@fusionio.com>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: linux-nilfs <linux-nilfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nilfs2: fix oops due to a bad aops initialization
Date: Wed, 30 Mar 2011 13:07:46 +0200 [thread overview]
Message-ID: <4D930F02.4070409@fusionio.com> (raw)
In-Reply-To: <20110330.132555.158630340.ryusuke@osrg.net>
On 2011-03-30 06:25, Ryusuke Konishi wrote:
> diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c
> index 4d2a1ee..9d2dc6b 100644
> --- a/fs/nilfs2/page.c
> +++ b/fs/nilfs2/page.c
> @@ -495,12 +495,14 @@ unsigned nilfs_page_count_clean_buffers(struct page *page,
> void nilfs_mapping_init(struct address_space *mapping,
> struct backing_dev_info *bdi)
> {
> + static const struct address_space_operations empty_aops;
> +
> mapping->host = NULL;
> mapping->flags = 0;
> mapping_set_gfp_mask(mapping, GFP_NOFS);
> mapping->assoc_mapping = NULL;
> mapping->backing_dev_info = bdi;
> - mapping->a_ops = NULL;
> + mapping->a_ops = &empty_aops;
> }
Hmm wait, inode init should set the mapping aops to an empty type
already. Does the OOPS go away if you just remove the mapping->a_ops =
NULL assignment?
--
Jens Axboe
next prev parent reply other threads:[~2011-03-30 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 4:25 [PATCH] nilfs2: fix oops due to a bad aops initialization Ryusuke Konishi
2011-03-30 7:47 ` Jens Axboe
[not found] ` <20110330.132555.158630340.ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-03-30 11:07 ` Jens Axboe [this message]
2011-03-30 11:07 ` Jens Axboe
2011-03-30 11:17 ` Jens Axboe
[not found] ` <4D93113E.2070805-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
2011-03-30 11:48 ` Ryusuke Konishi
2011-03-30 11:48 ` Ryusuke Konishi
[not found] ` <20110330.204832.186542149.ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-03-30 11:51 ` Jens Axboe
2011-03-30 11:51 ` Jens Axboe
[not found] ` <4D930F02.4070409-5c4llco8/ftWk0Htik3J/w@public.gmane.org>
2011-03-30 11:22 ` Ryusuke Konishi
2011-03-30 11:22 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D930F02.4070409@fusionio.com \
--to=jaxboe-5c4llco8/ftwk0htik3j/w@public.gmane.org \
--cc=konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.