From: Avi Kivity <avi@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: kvm@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2/2] kvm/x86: remove unneeded substitute search for missing CPUID entries
Date: Wed, 30 Mar 2011 15:33:29 +0200 [thread overview]
Message-ID: <4D933129.3050509@redhat.com> (raw)
In-Reply-To: <4D932F69.8070205@redhat.com>
On 03/30/2011 03:26 PM, Avi Kivity wrote:
>
> This behaviour is mandated by the spec (looking at the Intel one),
> though it is implemented incorrectly - should always return largest
> basic leaf, and ignore the kvm leaves.
>
> I think the correct behaviour is:
>
> if (e->function < 10000 && (!best || e->function > best->function))
> best = e;
>
Oh, and it should honor ecx.. what a great interface.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-03-30 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 13:01 [PATCH 1/2] kvm/x86: fix XSAVE bit scanning Andre Przywara
2011-03-30 13:01 ` [PATCH 2/2] kvm/x86: remove unneeded substitute search for missing CPUID entries Andre Przywara
2011-03-30 13:26 ` Avi Kivity
2011-03-30 13:33 ` Avi Kivity [this message]
2011-03-31 10:12 ` Andre Przywara
2011-03-31 10:32 ` Avi Kivity
2011-03-31 13:13 ` [PATCH 2/2] kvm/x86: move and fix substitue " Andre Przywara
2011-03-31 13:17 ` Avi Kivity
2011-03-31 14:50 ` Andre Przywara
2011-03-31 14:58 ` [PATCH 2/2 v3] " Andre Przywara
2011-04-03 12:32 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D933129.3050509@redhat.com \
--to=avi@redhat.com \
--cc=andre.przywara@amd.com \
--cc=kvm@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.