From: Avi Kivity <avi@redhat.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: kvm@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2/2 v3] kvm/x86: move and fix substitue search for missing CPUID entries
Date: Sun, 03 Apr 2011 15:32:16 +0300 [thread overview]
Message-ID: <4D9868D0.80300@redhat.com> (raw)
In-Reply-To: <1301583529-3130-1-git-send-email-andre.przywara@amd.com>
On 03/31/2011 04:58 PM, Andre Przywara wrote:
> If KVM cannot find an exact match for a requested CPUID leaf, the
> code will try to find the closest match instead of simply confessing
> it's failure.
> The implementation was meant to satisfy the CPUID specification, but
> did not properly check for extended and standard leaves and also
> didn't account for the index subleaf.
> Beside that this rule only applies to CPUID intercepts, which is not
> the only user of the kvm_find_cpuid_entry() function.
>
> So fix this algorithm and call it from kvm_emulate_cpuid().
> This fixes a crash of newer Linux kernels as KVM guests on
> AMD Bulldozer CPUs, where bogus values were returned in response to
> a CPUID intercept.
>
Thanks, applied and queued both for 2.6.39.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-04-03 12:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 13:01 [PATCH 1/2] kvm/x86: fix XSAVE bit scanning Andre Przywara
2011-03-30 13:01 ` [PATCH 2/2] kvm/x86: remove unneeded substitute search for missing CPUID entries Andre Przywara
2011-03-30 13:26 ` Avi Kivity
2011-03-30 13:33 ` Avi Kivity
2011-03-31 10:12 ` Andre Przywara
2011-03-31 10:32 ` Avi Kivity
2011-03-31 13:13 ` [PATCH 2/2] kvm/x86: move and fix substitue " Andre Przywara
2011-03-31 13:17 ` Avi Kivity
2011-03-31 14:50 ` Andre Przywara
2011-03-31 14:58 ` [PATCH 2/2 v3] " Andre Przywara
2011-04-03 12:32 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9868D0.80300@redhat.com \
--to=avi@redhat.com \
--cc=andre.przywara@amd.com \
--cc=kvm@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.