From: Lars-Peter Clausen <lars@metafoo.de>
To: Chris Ball <cjb@laptop.org>
Cc: Shawn Guo <shawn.guo@freescale.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
Date: Wed, 30 Mar 2011 18:46:17 +0200 [thread overview]
Message-ID: <4D935E59.2020908@metafoo.de> (raw)
In-Reply-To: <m37hbihenx.fsf@pullcord.laptop.org>
On 03/29/2011 03:57 AM, Chris Ball wrote:
> Hi Shawn,
>
> On Mon, Mar 28 2011, Shawn Guo wrote:
>> Hi Chris,
>>
>> Any comment on this one?
>
> Yep, I'll push it to mmc-next once -rc1 is released.
>
> Thanks,
>
> - Chris.
That patch doesn't make much sense. The config options are used to decide
whether support for that platform should be build into the sdhci-platform or
sdhci-of module. So setting them 'm' doesn't make any sense, since you can't
build part of an module as a module. The effect for 'm' will probably be the
same as for 'n'.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate'
Date: Wed, 30 Mar 2011 18:46:17 +0200 [thread overview]
Message-ID: <4D935E59.2020908@metafoo.de> (raw)
In-Reply-To: <m37hbihenx.fsf@pullcord.laptop.org>
On 03/29/2011 03:57 AM, Chris Ball wrote:
> Hi Shawn,
>
> On Mon, Mar 28 2011, Shawn Guo wrote:
>> Hi Chris,
>>
>> Any comment on this one?
>
> Yep, I'll push it to mmc-next once -rc1 is released.
>
> Thanks,
>
> - Chris.
That patch doesn't make much sense. The config options are used to decide
whether support for that platform should be build into the sdhci-platform or
sdhci-of module. So setting them 'm' doesn't make any sense, since you can't
build part of an module as a module. The effect for 'm' will probably be the
same as for 'n'.
- Lars
next prev parent reply other threads:[~2011-03-30 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 14:54 [PATCH] mmc: change CONFIG of MMC_SDHCI based drivers from 'bool' to 'tristate' Shawn Guo
2011-03-14 14:54 ` Shawn Guo
2011-03-28 14:38 ` Shawn Guo
2011-03-28 14:38 ` Shawn Guo
2011-03-29 1:57 ` Chris Ball
2011-03-29 1:57 ` Chris Ball
2011-03-30 16:46 ` Lars-Peter Clausen [this message]
2011-03-30 16:46 ` Lars-Peter Clausen
2011-03-30 16:57 ` Chris Ball
2011-03-30 16:57 ` Chris Ball
2011-03-31 1:37 ` Shawn Guo
2011-03-31 1:37 ` Shawn Guo
2011-03-31 1:31 ` [PATCH] mmc: sdhci: change CONFIG of MMC_SDHCI_TEGRA from 'tristate' to 'bool' Shawn Guo
2011-03-31 1:31 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D935E59.2020908@metafoo.de \
--to=lars@metafoo.de \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.