From: Huang Shijie <b32955@freescale.com>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 2/6] dmaengine: add interrupt check for GPMI controller
Date: Fri, 1 Apr 2011 12:36:50 +0800 [thread overview]
Message-ID: <4D955662.6010309@freescale.com> (raw)
In-Reply-To: <20110401034730.GE25866@S2100-06.ap.freescale.net>
hi:
> On Thu, Mar 31, 2011 at 05:08:54PM +0800, Huang Shijie wrote:
> [...]
>>>>> You should make the distinction based on the platform_id, which would
>>>>> save you the ugly ifdef's and cpu_is_... macros.
>>>>>
>>>>>
>>>> This in the DMA driver.
>>>> Do you want me to change the DMA driver to add the platform_id?
>>>> The DMA driver has already used the cpu_is_xx() macros.
>>>>
>>> The mxs-dma driver is already using platform ids!
>>>
>>>
>> Do you mean the mxd_dma_type[] ?
>>
>> How can i distinction the imx23 and imx28 with it ?
>> It seems can not be used to do the work.
>>
> You can drop the dmaengine patch from your gpmi series. I will find
> some time to fix this together with removing cpu_is_xx() and inclusion
> of mxs.h, to get it prepared for i.mx50 aphb-dma support.
>
ok, thanks.
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/6] dmaengine: add interrupt check for GPMI controller
Date: Fri, 1 Apr 2011 12:36:50 +0800 [thread overview]
Message-ID: <4D955662.6010309@freescale.com> (raw)
In-Reply-To: <20110401034730.GE25866@S2100-06.ap.freescale.net>
hi:
> On Thu, Mar 31, 2011 at 05:08:54PM +0800, Huang Shijie wrote:
> [...]
>>>>> You should make the distinction based on the platform_id, which would
>>>>> save you the ugly ifdef's and cpu_is_... macros.
>>>>>
>>>>>
>>>> This in the DMA driver.
>>>> Do you want me to change the DMA driver to add the platform_id?
>>>> The DMA driver has already used the cpu_is_xx() macros.
>>>>
>>> The mxs-dma driver is already using platform ids!
>>>
>>>
>> Do you mean the mxd_dma_type[] ?
>>
>> How can i distinction the imx23 and imx28 with it ?
>> It seems can not be used to do the work.
>>
> You can drop the dmaengine patch from your gpmi series. I will find
> some time to fix this together with removing cpu_is_xx() and inclusion
> of mxs.h, to get it prepared for i.mx50 aphb-dma support.
>
ok, thanks.
Huang Shijie
next prev parent reply other threads:[~2011-04-01 4:36 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 8:40 [PATCH V3 0/6] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-03-30 8:40 ` Huang Shijie
2011-03-30 8:40 ` [PATCH V3 1/6] ARM: add GPMI support for imx23/imx28 Huang Shijie
2011-03-30 8:40 ` Huang Shijie
2011-03-30 8:40 ` [PATCH V3 2/6] dmaengine: change the flags of request_irq() Huang Shijie
2011-03-30 8:40 ` Huang Shijie
2011-03-30 9:03 ` Lothar Waßmann
2011-03-30 9:03 ` Lothar Waßmann
2011-03-30 9:13 ` Shawn Guo
2011-03-30 9:13 ` Shawn Guo
2011-03-30 9:15 ` Lothar Waßmann
2011-03-30 9:15 ` Lothar Waßmann
2011-03-30 9:44 ` Huang Shijie
2011-03-30 9:44 ` Huang Shijie
2011-03-31 7:02 ` [PATCH V3 2/6] dmaengine: add interrupt check for GPMI controller Huang Shijie
2011-03-31 7:02 ` Huang Shijie
2011-03-31 8:02 ` Lothar Waßmann
2011-03-31 8:02 ` Lothar Waßmann
2011-03-31 8:50 ` Huang Shijie
2011-03-31 8:50 ` Huang Shijie
2011-03-31 8:50 ` Lothar Waßmann
2011-03-31 8:50 ` Lothar Waßmann
2011-03-31 9:08 ` Huang Shijie
2011-03-31 9:08 ` Huang Shijie
2011-03-31 9:34 ` Lothar Waßmann
2011-03-31 9:34 ` Lothar Waßmann
2011-04-01 3:47 ` Shawn Guo
2011-04-01 3:47 ` Shawn Guo
2011-04-01 4:36 ` Huang Shijie [this message]
2011-04-01 4:36 ` Huang Shijie
2011-03-30 8:40 ` [PATCH V3 3/6] MTD : add the database for the NANDs Huang Shijie
2011-03-30 8:40 ` Huang Shijie
2011-03-30 8:46 ` Florian Fainelli
2011-03-30 8:46 ` Florian Fainelli
2011-03-30 9:05 ` Huang Shijie
2011-03-30 9:05 ` Huang Shijie
2011-03-30 9:23 ` Florian Fainelli
2011-03-30 9:23 ` Florian Fainelli
2011-03-30 9:54 ` Huang Shijie
2011-03-30 9:54 ` Huang Shijie
2011-03-31 10:10 ` Artem Bityutskiy
2011-03-31 10:10 ` Artem Bityutskiy
2011-03-31 14:17 ` Huang Shijie
2011-03-31 14:17 ` Huang Shijie
2011-09-14 15:44 ` Brian Norris
2011-09-14 15:44 ` Brian Norris
2011-09-15 2:21 ` Huang Shijie
2011-09-15 2:21 ` Huang Shijie
2011-09-16 8:11 ` Angus CLARK
2011-11-21 22:18 ` Brian Norris
2011-12-06 12:06 ` Angus CLARK
2011-11-24 3:11 ` Huang Shijie
2011-11-24 3:11 ` Huang Shijie
2011-03-30 8:40 ` [PATCH V3 4/6] MTD : add the common code for GPMI controller driver Huang Shijie
2011-07-08 16:46 ` Huang Shijie
2011-03-30 8:40 ` [PATCH V3 5/6] MTD: add support for imx23 and imx28 Huang Shijie
2011-03-30 8:40 ` Huang Shijie
2011-03-30 8:40 ` [PATCH V3 6/6] MTD : add GPMI driver in the config and Makefile Huang Shijie
2011-03-30 8:40 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D955662.6010309@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.