All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
	quintela@redhat.com
Subject: [Qemu-devel] Re: [PATCH V3] floppy: save and restore DIR register
Date: Fri, 01 Apr 2011 08:54:34 +0200	[thread overview]
Message-ID: <4D9576AA.1040803@redhat.com> (raw)
In-Reply-To: <1301638940-22372-1-git-send-email-jasowang@redhat.com>

On 04/01/11 08:22, Jason Wang wrote:
> We need to keep DIR register unchanged across migration, but currently it
> depends on the media_changed flags from block layer. Since we do not
> save/restore it and the bdrv_open() called in dest node may set the
> media_changed flag when trying to open floppy image, guest driver may think the
> floppy have changed after migration. To fix this, a new filed media_changed in
> FDrive strcutre was introduced in order to save and restore the it from block
> layer through pre_save/post_load callbacks.
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Looked through this, and it looks perfectly reasonable to me.

Reviewed-by: Jes Sorensen <Jes.Sorensen@redhat.com>

  reply	other threads:[~2011-04-01  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-01  6:22 [Qemu-devel] [PATCH V3] floppy: save and restore DIR register Jason Wang
2011-04-01  6:54 ` Jes Sorensen [this message]
2011-04-01  7:15 ` [Qemu-devel] " Paolo Bonzini
2011-04-01 10:03   ` Jason Wang
2011-04-01 11:22     ` Paolo Bonzini
2011-04-06  8:41     ` Juan Quintela
2011-04-06  9:18 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9576AA.1040803@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.