[Qemu-devel] Re: [PATCH V3] floppy: save and restore DIR register

[Paolo Bonzini <pbonzini@redhat.com>]

On 04/01/2011 08:22 AM, Jason Wang wrote:
> +
> +    if (drive->bs == NULL) {
> +        return 1;

Is it okay to return 1 here?  Have you tested the case when both the 
source and the target drives have no floppy?

(The "media_changed == 2" in my sample code was basically a way to save 
the "media present" state of the drive on the source).

> +    } else {
> +        drive->bs->media_changed = drive->media_changed;
> +        return 0;
> +    }

The code is also missing the case of a pc-0.14 machine.  The problem 
here is that the pc-0.15 machine hasn't been created yet, you get the 
honor. :(

Paolo