All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Greg KH <greg@kroah.com>
Cc: cliff.cai@analog.com, gregkh@suse.de, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH 1/2] staging: IIO driver for Analog Devices Digital Output Gyroscope ADXRS450
Date: Tue, 05 Apr 2011 20:46:32 +0100	[thread overview]
Message-ID: <4D9B7198.1090109@cam.ac.uk> (raw)
In-Reply-To: <20110405192130.GA10106@kroah.com>

On 04/05/11 20:21, Greg KH wrote:
> On Fri, Mar 25, 2011 at 12:05:57PM +0800, cliff.cai@analog.com wrote:
>> From: Cliff Cai <cliff.cai@analog.com>
>>
>> Add new IIO driver for Analog Devices digital output gyroscope ADXRS=
450
>>
>> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
>> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>=20
> This breaks the build:
>   CC [M]  drivers/staging/iio/gyro/adxrs450_core.o
> drivers/staging/iio/gyro/adxrs450_core.c:329:70: error: expected =E2=80=
=98)=E2=80=99 before numeric constant
> drivers/staging/iio/gyro/adxrs450_core.c:337:3: error: =E2=80=98iio_d=
ev_attr_gyro_z_quadrature_correction_raw=E2=80=99 undeclared here (not =
in a function)
> drivers/staging/iio/gyro/adxrs450_core.c:216:16: warning: =E2=80=98ad=
xrs450_read_quad=E2=80=99 defined but not used
>=20
> Please test your patches before you send them out, it wastes everyone=
's
> time when you don't :(

=46irst patch seems to have dropped off the start of this series.

The review version had:

[PATCH 1/3] Add MACRO for gyro quadrature correction

Guessing a typo in git command post adding acks
is the culprit here!

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Greg KH <greg@kroah.com>
Cc: cliff.cai@analog.com, gregkh@suse.de, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH 1/2] staging: IIO driver for Analog Devices Digital Output Gyroscope ADXRS450
Date: Tue, 05 Apr 2011 20:46:32 +0100	[thread overview]
Message-ID: <4D9B7198.1090109@cam.ac.uk> (raw)
In-Reply-To: <20110405192130.GA10106@kroah.com>

On 04/05/11 20:21, Greg KH wrote:
> On Fri, Mar 25, 2011 at 12:05:57PM +0800, cliff.cai@analog.com wrote:
>> From: Cliff Cai <cliff.cai@analog.com>
>>
>> Add new IIO driver for Analog Devices digital output gyroscope ADXRS450
>>
>> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
>> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> 
> This breaks the build:
>   CC [M]  drivers/staging/iio/gyro/adxrs450_core.o
> drivers/staging/iio/gyro/adxrs450_core.c:329:70: error: expected ‘)’ before numeric constant
> drivers/staging/iio/gyro/adxrs450_core.c:337:3: error: ‘iio_dev_attr_gyro_z_quadrature_correction_raw’ undeclared here (not in a function)
> drivers/staging/iio/gyro/adxrs450_core.c:216:16: warning: ‘adxrs450_read_quad’ defined but not used
> 
> Please test your patches before you send them out, it wastes everyone's
> time when you don't :(

First patch seems to have dropped off the start of this series.

The review version had:

[PATCH 1/3] Add MACRO for gyro quadrature correction

Guessing a typo in git command post adding acks
is the culprit here!

  reply	other threads:[~2011-04-05 19:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25  4:05 [PATCH 1/2] IIO driver for Analog Devices Digital Output Gyroscope ADXRS450 cliff.cai
2011-03-25  4:05 ` [PATCH 2/2] Add ABI document for gyro quadrature correction cliff.cai
2011-04-05 19:21 ` [PATCH 1/2] staging: IIO driver for Analog Devices Digital Output Gyroscope ADXRS450 Greg KH
2011-04-05 19:21   ` Greg KH
2011-04-05 19:46   ` Jonathan Cameron [this message]
2011-04-05 19:46     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9B7198.1090109@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=cliff.cai@analog.com \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.