From: Kevin Wolf <kwolf@redhat.com>
To: Nick Thomas <nick@bytemark.co.uk>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 4/5] NBD device: Separate out parsing configuration and opening sockets.
Date: Wed, 06 Apr 2011 12:32:49 +0200 [thread overview]
Message-ID: <4D9C4151.5090201@redhat.com> (raw)
In-Reply-To: <1298389495-20618-4-git-send-email-nick@bytemark.co.uk>
Am 22.02.2011 16:44, schrieb Nick Thomas:
> We also change the way the file parameter is parsed so IPv6 IP
> addresses can be used, e.g.: "drive=nbd:[::1]:5000"
>
> Signed-off-by: Nick Thomas <nick@bytemark.co.uk>
> ---
> block/nbd.c | 157 ++++++++++++++++++++++++++++++++++++++---------------------
> 1 files changed, 102 insertions(+), 55 deletions(-)
Sorry for the long delay. I have applied patches 1-4 to the block branch
now.
I think this one leaks s->export_name and s->host_spec, so please post a
follow-up patch that fixes this on top of this patch.
Patch 5 looks a bit harder to review, I'll try to get to soon anyway.
One thing that you already can fix before the real review is coding
style. For example, I see a lot of trailing whitespace in patch 5.
Kevin
parent reply other threads:[~2011-04-06 10:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1298389495-20618-4-git-send-email-nick@bytemark.co.uk>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9C4151.5090201@redhat.com \
--to=kwolf@redhat.com \
--cc=nick@bytemark.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.