* [Qemu-devel] Re: [PATCH 4/5] NBD device: Separate out parsing configuration and opening sockets.
[not found] ` <1298389495-20618-4-git-send-email-nick@bytemark.co.uk>
@ 2011-04-06 10:32 ` Kevin Wolf
0 siblings, 0 replies; only message in thread
From: Kevin Wolf @ 2011-04-06 10:32 UTC (permalink / raw)
To: Nick Thomas; +Cc: stefanha, qemu-devel
Am 22.02.2011 16:44, schrieb Nick Thomas:
> We also change the way the file parameter is parsed so IPv6 IP
> addresses can be used, e.g.: "drive=nbd:[::1]:5000"
>
> Signed-off-by: Nick Thomas <nick@bytemark.co.uk>
> ---
> block/nbd.c | 157 ++++++++++++++++++++++++++++++++++++++---------------------
> 1 files changed, 102 insertions(+), 55 deletions(-)
Sorry for the long delay. I have applied patches 1-4 to the block branch
now.
I think this one leaks s->export_name and s->host_spec, so please post a
follow-up patch that fixes this on top of this patch.
Patch 5 looks a bit harder to review, I'll try to get to soon anyway.
One thing that you already can fix before the real review is coding
style. For example, I see a lot of trailing whitespace in patch 5.
Kevin
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-04-06 10:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1298389495-20618-1-git-send-email-nick@bytemark.co.uk>
[not found] ` <1298389495-20618-4-git-send-email-nick@bytemark.co.uk>
2011-04-06 10:32 ` [Qemu-devel] Re: [PATCH 4/5] NBD device: Separate out parsing configuration and opening sockets Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.