From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: Use generic BUG() handler
Date: Wed, 06 Apr 2011 22:35:31 -0700 [thread overview]
Message-ID: <4D9D4D23.6000805@codeaurora.org> (raw)
In-Reply-To: <1302131890-20953-1-git-send-email-sjg@chromium.org>
On 4/6/2011 4:18 PM, Simon Glass wrote:
> v3: Remove old BUG() implementation in favor of this one.
> Remove the Backtrace: message (will submit this separately).
> Use ARM_EXIT_KEEP() so that some architectures can dump exit text at link time
> thanks to Stephen Boyd <sboyd@codeaurora.org> (although since we always
> define GENERIC_BUG this might be academic.)
Its not entirely academic because CONFIG_BUG=n and CONFIG_SMP_ON_UP=n
would allow us to remove the exit text. This could be huge for people
who want to cram kernel's onto space constrained devices.
> Rebase to linux-2.6.git master.
>
> Change-Id: I07d77c832e816f5ad2390e25f466ddf750adecf4
Don't forget to remove these before submitting to the patch tracker (and
sending to the list).
> diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h
> index 4d88425..2914724 100644
> --- a/arch/arm/include/asm/bug.h
> +++ b/arch/arm/include/asm/bug.h
> @@ -3,21 +3,58 @@
>
>
> #ifdef CONFIG_BUG
> -#ifdef CONFIG_DEBUG_BUGVERBOSE
> -extern void __bug(const char *file, int line) __attribute__((noreturn));
> -
> -/* give file/line information */
> -#define BUG() __bug(__FILE__, __LINE__)
Does anybody reference __bug() anymore? If not you can remove that too.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Simon Glass <sjg@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Joe Perches <joe@perches.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Alexander Shishkin <virtuoso@slind.org>,
Phil Carmody <ext-phil.2.carmody@nokia.com>,
Rabin Vincent <rabin@rab.in>,
linux-kernel@vger.kernel.org,
Omar Ramirez Luna <omar.ramirez@ti.com>,
Dave Martin <dave.martin@linaro.org>,
Simon Glass <sjg@google.com>
Subject: Re: [PATCH v3] ARM: Use generic BUG() handler
Date: Wed, 06 Apr 2011 22:35:31 -0700 [thread overview]
Message-ID: <4D9D4D23.6000805@codeaurora.org> (raw)
In-Reply-To: <1302131890-20953-1-git-send-email-sjg@chromium.org>
On 4/6/2011 4:18 PM, Simon Glass wrote:
> v3: Remove old BUG() implementation in favor of this one.
> Remove the Backtrace: message (will submit this separately).
> Use ARM_EXIT_KEEP() so that some architectures can dump exit text at link time
> thanks to Stephen Boyd <sboyd@codeaurora.org> (although since we always
> define GENERIC_BUG this might be academic.)
Its not entirely academic because CONFIG_BUG=n and CONFIG_SMP_ON_UP=n
would allow us to remove the exit text. This could be huge for people
who want to cram kernel's onto space constrained devices.
> Rebase to linux-2.6.git master.
>
> Change-Id: I07d77c832e816f5ad2390e25f466ddf750adecf4
Don't forget to remove these before submitting to the patch tracker (and
sending to the list).
> diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h
> index 4d88425..2914724 100644
> --- a/arch/arm/include/asm/bug.h
> +++ b/arch/arm/include/asm/bug.h
> @@ -3,21 +3,58 @@
>
>
> #ifdef CONFIG_BUG
> -#ifdef CONFIG_DEBUG_BUGVERBOSE
> -extern void __bug(const char *file, int line) __attribute__((noreturn));
> -
> -/* give file/line information */
> -#define BUG() __bug(__FILE__, __LINE__)
Does anybody reference __bug() anymore? If not you can remove that too.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-04-07 5:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 23:18 [PATCH v3] ARM: Use generic BUG() handler Simon Glass
2011-04-06 23:18 ` Simon Glass
2011-04-07 5:35 ` Stephen Boyd [this message]
2011-04-07 5:35 ` Stephen Boyd
2011-04-07 16:49 ` Simon Glass
2011-04-07 16:49 ` Simon Glass
2011-04-07 17:57 ` Stephen Boyd
2011-04-07 17:57 ` Stephen Boyd
2011-04-14 23:02 ` Simon Glass
2011-04-14 23:02 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9D4D23.6000805@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.