Re: [PATCH] nfsd41: make sure nfs server process OPEN with EXCLUSIVE4_1 correcttly

[Mi Jinlong <mijinlong@cn.fujitsu.com>]

J. Bruce Fields :
> On Wed, Apr 06, 2011 at 05:04:50PM +0800, Mi Jinlong wrote:
>> At the recent kernel(2.6.39-rc1),
> 
> (But this is not a regression, right?  This has been a problem all
> along.)

  Yes, I think it's just a problem.

> 
>> NFS server can't process OPEN with EXCLUSIVE4_1,
>> because NFS server call nfsd_create_v3 to create file instead implement a separate
>> one. But nfsd_create_v3 can't process createmode is EXCLUSIVE4_1.
> 
> Is our handling of the attributes correct in this case?  (See e.g. the
> op_bmval[1] assignment a few lines down.)

  There is no problem of the p_bmval[1] assignment a few lines down.
  According to rfc5661 18.16.3, EXCLUSIVE4_1 supports the setting of
  attributes at file creation, we don't need to set p_bmval[1] assignment
  as EXCLUSIVE.

  I think we should have a fix at nfsd_create_v3(), not at do_open_lookup().
  Please ignore the old patch, a new one is as following.

--
thanks,
Mi Jinlong

=============================================================================