From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417)
Date: Fri, 08 Apr 2011 15:44:33 +0200 [thread overview]
Message-ID: <4D9F1141.7090504@gmail.com> (raw)
In-Reply-To: <1302103913.4698.4.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On 06.04.2011 17:31, Alexander Kurtz wrote:
> Am Dienstag, den 05.04.2011, 23:27 +0200 schrieb Nicolas de Pesloüan:
>> Le 05/04/2011 22:53, Colin Watson a écrit :
>>
>>> On Unix-like systems, though, and particularly when it comes to shell,
>>> this often involves knowing about historical behaviour as well as
>>> current behaviour.
>> Thanks Colin, for clarifying this!!
>>
>> Very appreciated.
> Now that we've all learned something new again (at least I have ;-) ),
> let's go back to the main topic:
>
> What do you think of the patch itself?
The (big) patch is mostly fine except:
-Please don't add brances where not needed
-Please don't add quoting to constants like x since x or "x" are
strictly identical.
> Best regards
>
> Alexander Kurtz
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
next prev parent reply other threads:[~2011-04-08 13:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 12:55 [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417) Alexander Kurtz
2011-04-05 19:16 ` Nicolas de Pesloüan
2011-04-05 19:30 ` Colin Watson
2011-04-05 19:32 ` Alexander Kurtz
2011-04-05 19:47 ` Colin Watson
2011-04-05 20:07 ` Nicolas de Pesloüan
2011-04-05 20:53 ` Colin Watson
2011-04-05 21:27 ` Nicolas de Pesloüan
2011-04-06 15:31 ` Alexander Kurtz
2011-04-06 18:14 ` Nicolas de Pesloüan
2011-04-06 19:31 ` Colin Watson
2011-04-06 19:42 ` Nicolas de Pesloüan
2011-04-08 13:44 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2011-04-09 14:32 ` Alexander Kurtz
2011-04-10 13:33 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9F1141.7090504@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.