All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Kurtz <kurtz.alex@googlemail.com>
To: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417)
Date: Tue, 05 Apr 2011 21:32:40 +0200	[thread overview]
Message-ID: <1302031960.30533.7.camel@localhost> (raw)
In-Reply-To: <4D9B6A7D.4090306@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Am Dienstag, den 05.04.2011, 21:16 +0200 schrieb Nicolas de Pesloüan:
> Why do you use construct like "${x}" instead of "$x"?

Because code isn't written once and then stays untouched forever. It
changes over time and may be used in situations you did not anticipate.
Writing solid code (and in shell scripts that definitely includes
quoting your variables) avoids unnecessary bugs like this one.

I've just seen too many poorly written shell scripts with hidden
(sometimes even security-relevant) bugs to not do things properly.

And it looks cleaner ;-)

Best regards

Alexander Kurtz

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2011-04-05 19:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 12:55 [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417) Alexander Kurtz
2011-04-05 19:16 ` Nicolas de Pesloüan
2011-04-05 19:30   ` Colin Watson
2011-04-05 19:32   ` Alexander Kurtz [this message]
2011-04-05 19:47     ` Colin Watson
2011-04-05 20:07     ` Nicolas de Pesloüan
2011-04-05 20:53       ` Colin Watson
2011-04-05 21:27         ` Nicolas de Pesloüan
2011-04-06 15:31           ` Alexander Kurtz
2011-04-06 18:14             ` Nicolas de Pesloüan
2011-04-06 19:31               ` Colin Watson
2011-04-06 19:42                 ` Nicolas de Pesloüan
2011-04-08 13:44             ` Vladimir 'φ-coder/phcoder' Serbinenko
2011-04-09 14:32               ` Alexander Kurtz
2011-04-10 13:33                 ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302031960.30533.7.camel@localhost \
    --to=kurtz.alex@googlemail.com \
    --cc=grub-devel@gnu.org \
    --cc=nicolas.2p.debian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.