[PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel

[PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel

[Philippe Nunes]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

---
 doc/stk-api.txt |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/doc/stk-api.txt b/doc/stk-api.txt
index 0bcc6b5..aaa9fba 100644
--- a/doc/stk-api.txt
+++ b/doc/stk-api.txt
@@ -278,6 +278,13 @@ Methods		byte RequestSelection(string title, byte icon_id,
 
 			Possible Errors: [service].Error.SimToolkit.EndSession
 
+		boolean ConfirmOpenChannel(string information, byte icon_id)
+
+			Asks the agent to request user to confirm the channel
+			set-up.
+
+			Possible Errors: [service].Error.SimToolkit.EndSession
+
 		void Cancel() [noreply]
 
 			Asks the agent to cancel any ongoing operation in
-- 
1.7.1

Re: [PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Hi Philippe,

>  doc/stk-api.txt |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/doc/stk-api.txt b/doc/stk-api.txt
> index 0bcc6b5..aaa9fba 100644
> --- a/doc/stk-api.txt
> +++ b/doc/stk-api.txt
> @@ -278,6 +278,13 @@ Methods		byte RequestSelection(string title, byte icon_id,
>  
>  			Possible Errors: [service].Error.SimToolkit.EndSession
>  
> +		boolean ConfirmOpenChannel(string information, byte icon_id)
> +
> +			Asks the agent to request user to confirm the channel
> +			set-up.
> +
> +			Possible Errors: [service].Error.SimToolkit.EndSession
> +

we need to talk a bit about these boolean return parameters for
confirmation. Since essentially a positive D-Bus reply can be considered
as TRUE and a D-Bus error as FALSE. So this essentially implicit.

You can not return FALSE and an error. That is not how D-Bus works.

Regards

Marcel

Re: [PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]

Hi Marcel,

On 04/08/2011 11:36 AM, Marcel Holtmann wrote:
> Hi Philippe,
> 
>>  doc/stk-api.txt |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/doc/stk-api.txt b/doc/stk-api.txt
>> index 0bcc6b5..aaa9fba 100644
>> --- a/doc/stk-api.txt
>> +++ b/doc/stk-api.txt
>> @@ -278,6 +278,13 @@ Methods		byte RequestSelection(string title, byte icon_id,
>>  
>>  			Possible Errors: [service].Error.SimToolkit.EndSession
>>  
>> +		boolean ConfirmOpenChannel(string information, byte icon_id)
>> +
>> +			Asks the agent to request user to confirm the channel
>> +			set-up.
>> +
>> +			Possible Errors: [service].Error.SimToolkit.EndSession
>> +
> 
> we need to talk a bit about these boolean return parameters for
> confirmation. Since essentially a positive D-Bus reply can be considered
> as TRUE and a D-Bus error as FALSE. So this essentially implicit.
> 
> You can not return FALSE and an error. That is not how D-Bus works.

Actually I'm fine with this.  The error has a different intent.

There are three potential outcomes of this operation:

- User accepts (True)
- User Rejects (False)
- User decides to end the session, which in addition to rejecting the
command as above, also reboots the STK session.

Unless you want to introduce org.ofono.Error.SimToolkit.UserRejected,
which to me looks ugly.

Regards,
-Denis

Re: [PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 1813 bytes --]

Hi Denis,

> >>  doc/stk-api.txt |    7 +++++++
> >>  1 files changed, 7 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/doc/stk-api.txt b/doc/stk-api.txt
> >> index 0bcc6b5..aaa9fba 100644
> >> --- a/doc/stk-api.txt
> >> +++ b/doc/stk-api.txt
> >> @@ -278,6 +278,13 @@ Methods		byte RequestSelection(string title, byte icon_id,
> >>  
> >>  			Possible Errors: [service].Error.SimToolkit.EndSession
> >>  
> >> +		boolean ConfirmOpenChannel(string information, byte icon_id)
> >> +
> >> +			Asks the agent to request user to confirm the channel
> >> +			set-up.
> >> +
> >> +			Possible Errors: [service].Error.SimToolkit.EndSession
> >> +
> > 
> > we need to talk a bit about these boolean return parameters for
> > confirmation. Since essentially a positive D-Bus reply can be considered
> > as TRUE and a D-Bus error as FALSE. So this essentially implicit.
> > 
> > You can not return FALSE and an error. That is not how D-Bus works.
> 
> Actually I'm fine with this.  The error has a different intent.
> 
> There are three potential outcomes of this operation:
> 
> - User accepts (True)
> - User Rejects (False)
> - User decides to end the session, which in addition to rejecting the
> command as above, also reboots the STK session.
> 
> Unless you want to introduce org.ofono.Error.SimToolkit.UserRejected,
> which to me looks ugly.

so within BlueZ, we did exactly that. We introduced an error to be able
to reject this. Mainly since we actually expected an accept reply with
data.

I don't find the rejected error ugly, but that is more like a personal
preference. I can see both arguments here.

Anyhow if we keep it this way, then the documentation needs to clearly
state the above with true == accept and false == reject.

Regards

Marcel

Re: [PATCH 2/6] stk-api.txt. Introduce the new API ConfirmOpenChannel

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

Hi Philippe,

On 04/08/2011 11:33 AM, Philippe Nunes wrote:
> ---
>  doc/stk-api.txt |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis