[patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[Colin Walters]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

    Non-verbose logs are really annoying when trying to debug a build
    failure.  A lot of projects are copying in the flag to use
    AM_SILENT_RULES which automake gained recently.  We need to undo
    this.

    Implement this by overriding do_compile in autotools to look for
    its signature, and specify V=1 to make if we find it.

[-- Attachment #2: 0001-autotools-Override-do_compile-to-specify-V-1-if-proj.patch --]
[-- Type: text/x-patch, Size: 1494 bytes --]

From eb7869c1b300b1e0815708ce44a108e4b8add32d Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Wed, 23 Mar 2011 18:28:36 -0400
Subject: [PATCH] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

Non-verbose logs are really annoying when trying to debug a build
failure.  A lot of projects are copying in the flag to use
AM_SILENT_RULES which automake gained recently.  We need to undo
this.

Implement this by overriding do_compile in autotools to look for
its signature, and specify V=1 to make if we find it.
---
 meta/classes/autotools.bbclass |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index bc891f9..04d5e2d 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -156,6 +156,15 @@ autotools_do_configure() {
 	fi
 }
 
+# Override base compilation with one that undoes AM_SILENT_RULES; we
+# want the full logs.
+autotools_do_compile() {
+	if grep -q AM_V_GEN Makefile 2>/dev/null; then
+		AM_V_OVERRIDE="V=1"
+	fi
+	${MAKE} ${AM_V_OVERRIDE} ${EXTRA_OEMAKE} "$@" || die "oe_runmake failed"
+}
+
 autotools_do_install() {
 	oe_runmake 'DESTDIR=${D}' install
 	# Info dir listing isn't interesting at this point so remove it if it exists.
@@ -166,4 +175,4 @@ autotools_do_install() {
 
 inherit siteconfig
 
-EXPORT_FUNCTIONS do_configure do_install
+EXPORT_FUNCTIONS do_configure do_compile do_install
-- 
1.7.4

Re: [patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[Khem Raj]

On (23/03/11 18:30), Colin Walters wrote:
>     Non-verbose logs are really annoying when trying to debug a build
>     failure.  A lot of projects are copying in the flag to use
>     AM_SILENT_RULES which automake gained recently.  We need to undo
>     this.
> 
>     Implement this by overriding do_compile in autotools to look for
>     its signature, and specify V=1 to make if we find it.

usually package which use silent-rules they have --disable-silent-rules
Did you try to pass this option ? May be try it with EXTRA_OECONF and
see if that helps

but if this patch it needed then ${MAKE} call should become oe_runmake

-- 
-Khem

Re: [patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[Colin Walters]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

On Wed, Mar 23, 2011 at 11:19 PM, Khem Raj <raj.khem@gmail.com> wrote:

> usually package which use silent-rules they have --disable-silent-rules
> Did you try to pass this option ? May be try it with EXTRA_OECONF and
> see if that helps

You're right, that's much better.  New patch attached:

[-- Attachment #2: 0001-autotools-Pass-disable-silent-rules-to-configure.patch --]
[-- Type: text/x-patch, Size: 1019 bytes --]

From 1fa53a2f1c457ef0fb0df7ada53c67dd87d18448 Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Wed, 23 Mar 2011 18:28:36 -0400
Subject: [PATCH] autotools: Pass --disable-silent-rules to configure

Non-verbose logs are really annoying when trying to debug a build
failure.  A lot of projects are copying in the flag to use
AM_SILENT_RULES which automake gained recently.  We need to undo
this.

We'll get a warning from configure if it's not recognized, but that's
fine.
---
 meta/classes/autotools.bbclass |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index bc891f9..7ebf833 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -63,6 +63,7 @@ CONFIGUREOPTS = " --build=${BUILD_SYS} \
 		  --oldincludedir=${oldincludedir} \
 		  --infodir=${infodir} \
 		  --mandir=${mandir} \
+		  --disable-silent-rules \
 		  ${@append_libtool_sysroot(d)}"
 
 oe_runconf () {
-- 
1.7.4

Re: [patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[Colin Walters]

On Fri, Mar 25, 2011 at 8:41 AM, Colin Walters <walters@verbum.org> wrote:
> On Wed, Mar 23, 2011 at 11:19 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
>> usually package which use silent-rules they have --disable-silent-rules
>> Did you try to pass this option ? May be try it with EXTRA_OECONF and
>> see if that helps
>
> You're right, that's much better.  New patch attached:

Any opinion on the new patch?

Re: [patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[Khem Raj]

On Fri, 2011-04-08 at 17:07 -0400, Colin Walters wrote:
> On Fri, Mar 25, 2011 at 8:41 AM, Colin Walters <walters@verbum.org> wrote:
> > On Wed, Mar 23, 2011 at 11:19 PM, Khem Raj <raj.khem@gmail.com> wrote:
> >
> >> usually package which use silent-rules they have --disable-silent-rules
> >> Did you try to pass this option ? May be try it with EXTRA_OECONF and
> >> see if that helps
> >
> > You're right, that's much better.  New patch attached:
> 
> Any opinion on the new patch?

Looks ok to me however it needs to be tested build atleast all packages
that use autotools

Re: [patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[Saul Wold]

On 04/08/2011 05:00 PM, Khem Raj wrote:
> On Fri, 2011-04-08 at 17:07 -0400, Colin Walters wrote:
>> On Fri, Mar 25, 2011 at 8:41 AM, Colin Walters<walters@verbum.org>  wrote:
>>> On Wed, Mar 23, 2011 at 11:19 PM, Khem Raj<raj.khem@gmail.com>  wrote:
>>>
>>>> usually package which use silent-rules they have --disable-silent-rules
>>>> Did you try to pass this option ? May be try it with EXTRA_OECONF and
>>>> see if that helps
>>>
>>> You're right, that's much better.  New patch attached:
>>
>> Any opinion on the new patch?
>
> Looks ok to me however it needs to be tested build atleast all packages
> that use autotools
>
I have integrated this patch locally and I am working on a full world 
build of a couple of Machines, looking good so far, will be pulled later
this weekend.

Sau!

> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>

Re: [patch] autotools: Override do_compile to specify V=1 if project uses AM_V_GEN

[Saul Wold]

On 03/23/2011 03:30 PM, Colin Walters wrote:
>      Non-verbose logs are really annoying when trying to debug a build
>      failure.  A lot of projects are copying in the flag to use
>      AM_SILENT_RULES which automake gained recently.  We need to undo
>      this.
>
>      Implement this by overriding do_compile in autotools to look for
>      its signature, and specify V=1 to make if we find it.
>
>
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

Updated version is now merged into oe-core and master

Thanks
	Sau!