[PATCH] slub: Fix a typo in config name

[PATCH] slub: Fix a typo in config name

[Li Zefan]

There's no config named SLAB_DEBUG, and it should be a typo
of SLUB_DEBUG.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---

not slub expert, don't know how this bug affects slub debugging.

---
 mm/slub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 94d2a33..df77f78 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3203,7 +3203,7 @@ static void __init kmem_cache_bootstrap_fixup(struct kmem_cache *s)
 			list_for_each_entry(p, &n->partial, lru)
 				p->slab = s;
 
-#ifdef CONFIG_SLAB_DEBUG
+#ifdef CONFIG_SLUB_DEBUG
 			list_for_each_entry(p, &n->full, lru)
 				p->slab = s;
 #endif
-- 
1.7.3.1

[PATCH] slub: Fix a typo in config name

[Li Zefan]

There's no config named SLAB_DEBUG, and it should be a typo
of SLUB_DEBUG.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---

not slub expert, don't know how this bug affects slub debugging.

---
 mm/slub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 94d2a33..df77f78 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3203,7 +3203,7 @@ static void __init kmem_cache_bootstrap_fixup(struct kmem_cache *s)
 			list_for_each_entry(p, &n->partial, lru)
 				p->slab = s;
 
-#ifdef CONFIG_SLAB_DEBUG
+#ifdef CONFIG_SLUB_DEBUG
 			list_for_each_entry(p, &n->full, lru)
 				p->slab = s;
 #endif
-- 
1.7.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] slub: Fix a typo in config name

[Christoph Lameter]

On Tue, 12 Apr 2011, Li Zefan wrote:

> There's no config named SLAB_DEBUG, and it should be a typo
> of SLUB_DEBUG.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
>
> not slub expert, don't know how this bug affects slub debugging.

Affects the bootstrap code.

Acked-by: Christoph Lameter <cl@linux.com>

Re: [PATCH] slub: Fix a typo in config name

[Christoph Lameter]

On Tue, 12 Apr 2011, Li Zefan wrote:

> There's no config named SLAB_DEBUG, and it should be a typo
> of SLUB_DEBUG.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
>
> not slub expert, don't know how this bug affects slub debugging.

Affects the bootstrap code.

Acked-by: Christoph Lameter <cl@linux.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] slub: Fix a typo in config name

[David Rientjes]

On Tue, 12 Apr 2011, Christoph Lameter wrote:

> On Tue, 12 Apr 2011, Li Zefan wrote:
> 
> > There's no config named SLAB_DEBUG, and it should be a typo
> > of SLUB_DEBUG.
> >
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > ---
> >
> > not slub expert, don't know how this bug affects slub debugging.
> 
> Affects the bootstrap code.
> 

I don't see how, there should be no partial or full slabs for either 
kmem_cache or kmem_cache_node at this point in the boot sequence.  I think 
kmem_cache_bootstrap_fixup() should only need to add the cache to the list 
of slab caches and set the refcount accordingly.

Re: [PATCH] slub: Fix a typo in config name

[David Rientjes]

On Tue, 12 Apr 2011, Christoph Lameter wrote:

> On Tue, 12 Apr 2011, Li Zefan wrote:
> 
> > There's no config named SLAB_DEBUG, and it should be a typo
> > of SLUB_DEBUG.
> >
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > ---
> >
> > not slub expert, don't know how this bug affects slub debugging.
> 
> Affects the bootstrap code.
> 

I don't see how, there should be no partial or full slabs for either 
kmem_cache or kmem_cache_node at this point in the boot sequence.  I think 
kmem_cache_bootstrap_fixup() should only need to add the cache to the list 
of slab caches and set the refcount accordingly.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] slub: Fix a typo in config name

[Christoph Lameter]

On Tue, 12 Apr 2011, David Rientjes wrote:

> On Tue, 12 Apr 2011, Christoph Lameter wrote:
>
> > On Tue, 12 Apr 2011, Li Zefan wrote:
> >
> > > There's no config named SLAB_DEBUG, and it should be a typo
> > > of SLUB_DEBUG.
> > >
> > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > > ---
> > >
> > > not slub expert, don't know how this bug affects slub debugging.
> >
> > Affects the bootstrap code.
> >
>
> I don't see how, there should be no partial or full slabs for either
> kmem_cache or kmem_cache_node at this point in the boot sequence.  I think
> kmem_cache_bootstrap_fixup() should only need to add the cache to the list
> of slab caches and set the refcount accordingly.

Hmmm... That depends on the number of objects in a slab page. If that is
one then we may have an issue.

Re: [PATCH] slub: Fix a typo in config name

[Christoph Lameter]

On Tue, 12 Apr 2011, David Rientjes wrote:

> On Tue, 12 Apr 2011, Christoph Lameter wrote:
>
> > On Tue, 12 Apr 2011, Li Zefan wrote:
> >
> > > There's no config named SLAB_DEBUG, and it should be a typo
> > > of SLUB_DEBUG.
> > >
> > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > > ---
> > >
> > > not slub expert, don't know how this bug affects slub debugging.
> >
> > Affects the bootstrap code.
> >
>
> I don't see how, there should be no partial or full slabs for either
> kmem_cache or kmem_cache_node at this point in the boot sequence.  I think
> kmem_cache_bootstrap_fixup() should only need to add the cache to the list
> of slab caches and set the refcount accordingly.

Hmmm... That depends on the number of objects in a slab page. If that is
one then we may have an issue.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>