From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2
Date: Tue, 12 Apr 2011 10:53:23 -0600 [thread overview]
Message-ID: <4DA48383.4000604@linaro.org> (raw)
In-Reply-To: <BANLkTin7DEWJt4PrBp85disqXd9ZBG3Z_g@mail.gmail.com>
On 11-04-12 07:44 AM, Ohad Ben-Cohen wrote:
> On Mon, Apr 11, 2011 at 6:24 PM,<mathieu.poirier@linaro.org> wrote:
>> From: Mathieu J. Poirier<mathieu.poirier@linaro.org>
>>
>> This is the second spin on STE's Hsem driver that is implemented
>> through the hwspinlock scheme. More specifically:
>>
>> More comments have been added in the code.
>> Cleanup of included header files.
>> One of the original contributor's name corrected.
>> Calls to 'pm_runtime_disable'restored.
>>
>> Signed-off-by: Mathieu Poirier<mathieu.poirier@linaro.org>
>> ---
> Looks good, but please revise the commit log (think of a random reader
> who tries to understand what does this patch do, and is less
> interested to hear about its revisions' history).
>
> Otherwise,
>
> Acked-by: Ohad Ben-Cohen<ohad@wizery.com>
>
> (btw I assume the "PATCH 1/2" in the subject is just a typo, and
> there's no missing "PATCH 2/2")
>
Ohad,
I will revise the commit log and send a V3. The PATCH 1/2 was generated
by send-email even if there was only one patch file... But you are
correct, there was only just one patch.
Mathieu.
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2
Date: Tue, 12 Apr 2011 10:53:23 -0600 [thread overview]
Message-ID: <4DA48383.4000604@linaro.org> (raw)
In-Reply-To: <BANLkTin7DEWJt4PrBp85disqXd9ZBG3Z_g@mail.gmail.com>
On 11-04-12 07:44 AM, Ohad Ben-Cohen wrote:
> On Mon, Apr 11, 2011 at 6:24 PM,<mathieu.poirier@linaro.org> wrote:
>> From: Mathieu J. Poirier<mathieu.poirier@linaro.org>
>>
>> This is the second spin on STE's Hsem driver that is implemented
>> through the hwspinlock scheme. More specifically:
>>
>> More comments have been added in the code.
>> Cleanup of included header files.
>> One of the original contributor's name corrected.
>> Calls to 'pm_runtime_disable'restored.
>>
>> Signed-off-by: Mathieu Poirier<mathieu.poirier@linaro.org>
>> ---
> Looks good, but please revise the commit log (think of a random reader
> who tries to understand what does this patch do, and is less
> interested to hear about its revisions' history).
>
> Otherwise,
>
> Acked-by: Ohad Ben-Cohen<ohad@wizery.com>
>
> (btw I assume the "PATCH 1/2" in the subject is just a typo, and
> there's no missing "PATCH 2/2")
>
Ohad,
I will revise the commit log and send a V3. The PATCH 1/2 was generated
by send-email even if there was only one patch file... But you are
correct, there was only just one patch.
Mathieu.
next prev parent reply other threads:[~2011-04-12 16:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 15:24 [PATCH 1/2] ux500: Adding support for u8500 Hsem functionality V2 mathieu.poirier at linaro.org
2011-04-11 15:24 ` mathieu.poirier
2011-04-12 13:44 ` Ohad Ben-Cohen
2011-04-12 13:44 ` Ohad Ben-Cohen
2011-04-12 16:53 ` Mathieu Poirier [this message]
2011-04-12 16:53 ` Mathieu Poirier
2011-04-12 17:46 ` Arnd Bergmann
2011-04-12 17:46 ` Arnd Bergmann
2011-04-12 19:13 ` Mathieu Poirier
2011-04-12 19:13 ` Mathieu Poirier
2011-04-13 8:45 ` Ohad Ben-Cohen
2011-04-13 8:45 ` Ohad Ben-Cohen
2011-04-17 20:39 ` Arnd Bergmann
2011-04-17 20:39 ` Arnd Bergmann
2011-04-19 16:06 ` Mathieu Poirier
2011-04-19 16:06 ` Mathieu Poirier
2011-04-19 16:10 ` Arnd Bergmann
2011-04-19 16:10 ` Arnd Bergmann
2011-09-05 21:09 ` Ohad Ben-Cohen
2011-09-05 21:09 ` Ohad Ben-Cohen
2011-09-06 7:15 ` Linus Walleij
2011-09-06 7:15 ` Linus Walleij
2011-09-06 7:27 ` Ohad Ben-Cohen
2011-09-06 7:27 ` Ohad Ben-Cohen
2011-04-13 8:16 ` Ohad Ben-Cohen
2011-04-13 8:16 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA48383.4000604@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.