[PATCH 4/6] stkutil.c: Send at least the data currently available

[PATCH 4/6] stkutil.c: Send at least the data currently available

[Philippe Nunes]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

---
 src/stkutil.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/stkutil.c b/src/stkutil.c
index 7299fb5..ee59841 100644
--- a/src/stkutil.c
+++ b/src/stkutil.c
@@ -5655,7 +5655,8 @@ static gboolean build_receive_data(struct stk_tlv_builder *builder,
 	const struct stk_response_receive_data *receive_data =
 		&response->receive_data;
 
-	if (response->result.type != STK_RESULT_TYPE_SUCCESS)
+	if (response->result.type != STK_RESULT_TYPE_SUCCESS &&
+			response->result.type != STK_RESULT_TYPE_MISSING_INFO)
 		return TRUE;
 
 	if (receive_data->rx_data.len) {
-- 
1.7.1

Re: [PATCH 4/6] stkutil.c: Send at least the data currently available

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Hi Philippe,

On 04/08/2011 11:33 AM, Philippe Nunes wrote:
> ---
>  src/stkutil.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/stkutil.c b/src/stkutil.c
> index 7299fb5..ee59841 100644
> --- a/src/stkutil.c
> +++ b/src/stkutil.c
> @@ -5655,7 +5655,8 @@ static gboolean build_receive_data(struct stk_tlv_builder *builder,
>  	const struct stk_response_receive_data *receive_data =
>  		&response->receive_data;
>  
> -	if (response->result.type != STK_RESULT_TYPE_SUCCESS)
> +	if (response->result.type != STK_RESULT_TYPE_SUCCESS &&
> +			response->result.type != STK_RESULT_TYPE_MISSING_INFO)
>  		return TRUE;
>  
>  	if (receive_data->rx_data.len) {

Does this check also belong on other data object builders?

Regards,
-Denis

Re: [PATCH 4/6] stkutil.c: Send at least the data currently available

[Philippe Nunes]

[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]

Hi Denis,

On 04/12/2011 06:40 AM, Denis Kenzior wrote:
> Hi Philippe,
>
> On 04/08/2011 11:33 AM, Philippe Nunes wrote:
>> ---
>>   src/stkutil.c |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/stkutil.c b/src/stkutil.c
>> index 7299fb5..ee59841 100644
>> --- a/src/stkutil.c
>> +++ b/src/stkutil.c
>> @@ -5655,7 +5655,8 @@ static gboolean build_receive_data(struct stk_tlv_builder *builder,
>>   	const struct stk_response_receive_data *receive_data =
>>   		&response->receive_data;
>>
>> -	if (response->result.type != STK_RESULT_TYPE_SUCCESS)
>> +	if (response->result.type != STK_RESULT_TYPE_SUCCESS&&
>> +			response->result.type != STK_RESULT_TYPE_MISSING_INFO)
>>   		return TRUE;
>>
>>   	if (receive_data->rx_data.len) {
>
> Does this check also belong on other data object builders?
>
> Regards,
> -Denis
>

Here the purpose of this check is to allow to return the data currently 
available in the channel buffer even if the terminal response is 
"Command performed with missing information".
Indeed, this status shall be set when the requested number of bytes is 
not yet available in the Rx buffer.

Now, the general result could also be set to "command performed, with 
missing information" when the terminal received at least the minimum set 
of component parts, but did not receive all of the parts that it 
believed mandatory for the UICC to send;
But, currently, we are always returning "Error, required values are 
missing" when this case occurs.
So far, only the terminal response for the proactive command 'Receive 
data' is therefore concerned by this check.

Regards,

Philippe.