All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on	ARM
Date: Wed, 13 Apr 2011 16:03:44 +0400	[thread overview]
Message-ID: <4DA59120.1070402@ru.mvista.com> (raw)
In-Reply-To: <201104122306.34909.jkrzyszt@tis.icnet.pl>

Hello.

On 13-04-2011 1:06, Janusz Krzysztofik wrote:

> After switching from mem->dma_handle to virt_to_phys(mem->vaddr) used
> for obtaining page frame number passed to remap_pfn_range()
> (commit 35d9f510b67b10338161aba6229d4f55b4000f5b), videobuf-dma-contig

    Please specify the commit summary -- for the human readers.

> stopped working on my ARM based board. The ARM architecture maintainer,
> Russell King, confirmed that using something like
> virt_to_phys(dma_alloc_coherent()) is not supported on ARM, and can be
> broken on other architectures as well. The author of the change, Jiri
> Slaby, also confirmed that his code may not work on all architectures.

> The patch tries to solve this regression by using
> virt_to_phys(bus_to_virt(mem->dma_handle)) instead of problematic
> virt_to_phys(mem->vaddr). I think this should work even if those
> translations would occure inaccurate for DMA addresses, since possible
> errors introduced by both translations, performed in opposite
> directions, should compensate.

> Tested on ARM OMAP1 based Amstrad Delta board.

> Signed-off-by: Janusz Krzysztofik<jkrzyszt@tis.icnet.pl>

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Jiri Slaby <jslaby@suse.cz>,
	linux-arm-kernel@lists.infradead.org,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on	ARM
Date: Wed, 13 Apr 2011 16:03:44 +0400	[thread overview]
Message-ID: <4DA59120.1070402@ru.mvista.com> (raw)
In-Reply-To: <201104122306.34909.jkrzyszt@tis.icnet.pl>

Hello.

On 13-04-2011 1:06, Janusz Krzysztofik wrote:

> After switching from mem->dma_handle to virt_to_phys(mem->vaddr) used
> for obtaining page frame number passed to remap_pfn_range()
> (commit 35d9f510b67b10338161aba6229d4f55b4000f5b), videobuf-dma-contig

    Please specify the commit summary -- for the human readers.

> stopped working on my ARM based board. The ARM architecture maintainer,
> Russell King, confirmed that using something like
> virt_to_phys(dma_alloc_coherent()) is not supported on ARM, and can be
> broken on other architectures as well. The author of the change, Jiri
> Slaby, also confirmed that his code may not work on all architectures.

> The patch tries to solve this regression by using
> virt_to_phys(bus_to_virt(mem->dma_handle)) instead of problematic
> virt_to_phys(mem->vaddr). I think this should work even if those
> translations would occure inaccurate for DMA addresses, since possible
> errors introduced by both translations, performed in opposite
> directions, should compensate.

> Tested on ARM OMAP1 based Amstrad Delta board.

> Signed-off-by: Janusz Krzysztofik<jkrzyszt@tis.icnet.pl>

WBR, Sergei

  parent reply	other threads:[~2011-04-13 12:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 21:06 [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM Janusz Krzysztofik
2011-04-12 21:06 ` Janusz Krzysztofik
2011-04-12 21:40 ` Russell King - ARM Linux
2011-04-12 21:40   ` Russell King - ARM Linux
2011-04-12 22:12   ` Theodore Kilgore
2011-04-12 22:12     ` Theodore Kilgore
2011-04-13 10:52   ` Janusz Krzysztofik
2011-04-13 10:52     ` Janusz Krzysztofik
2011-04-13 18:32     ` Russell King - ARM Linux
2011-04-13 18:32       ` Russell King - ARM Linux
2011-04-13 20:56       ` Janusz Krzysztofik
2011-04-13 20:56         ` Janusz Krzysztofik
2011-04-13 22:00         ` Russell King - ARM Linux
2011-04-13 22:00           ` Russell King - ARM Linux
2011-04-13 22:43           ` Janusz Krzysztofik
2011-04-13 22:43             ` Janusz Krzysztofik
2011-04-19  6:08           ` [REVERT] " Jiri Slaby
2011-04-19  6:08             ` Jiri Slaby
2011-04-19 12:37             ` Mauro Carvalho Chehab
2011-04-19 12:37               ` Mauro Carvalho Chehab
2011-04-13 12:03 ` Sergei Shtylyov [this message]
2011-04-13 12:03   ` [PATCH 2.6.39 v2] " Sergei Shtylyov
2011-04-13 13:11   ` Janusz Krzysztofik
2011-04-13 13:11     ` Janusz Krzysztofik
2011-04-13 17:36     ` Sergei Shtylyov
2011-04-13 17:36       ` Sergei Shtylyov
2011-04-13 21:01       ` Janusz Krzysztofik
2011-04-13 21:01         ` Janusz Krzysztofik
2011-04-13 21:16         ` Janusz Krzysztofik
2011-04-13 21:16           ` Janusz Krzysztofik
2011-04-15 12:25           ` Sergei Shtylyov
2011-04-15 12:25             ` Sergei Shtylyov
2011-04-14 11:17         ` Sergei Shtylyov
2011-04-14 11:17           ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA59120.1070402@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.