All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device
Date: Fri, 15 Apr 2011 16:55:58 +0200	[thread overview]
Message-ID: <4DA85C7E.6030403@suse.de> (raw)
In-Reply-To: <4DA85370.4080909@redhat.com>

On 04/15/2011 04:17 PM, Paolo Bonzini wrote:
> On 04/15/2011 04:01 PM, Stefan Hajnoczi wrote:
>> I think SCSI brings many benefits.  Guests can deal with it better
>> than these alien vdX virtio-blk devices, which makes migration easier.
>> It becomes possible to attach many disks without burning through free
>> PCI slots.  We don't need to update guests to add cache control,
>> discard, and other commands because they are part of SCSI.  We can
>> pass through more exotic devices.  The list goes on...
> 
> And we also have to reimplement all of MMC. :)
> 
> A few questions:
> 
> 1) Do you have anything posted for the virtio-scsi spec?  I had started
> working on one, but I haven't yet made it final.  It included also
> hotplug/unplug.  I can send it out on Monday.
> 
> 2) Have you thought about making scsi-disk and scsi-generic provide a
> logical unit rather than a target?  Otherwise passthrough of a whole
> host or target becomes hard or messy.
> 
> 3) Since I noticed Hannes is CCed, my next step for vmw_pvscsi would be
> to dust off his patches to remove the bounce buffers, and see how they
> apply to vmw_pvscsi.  But I'd like to avoid duplicated work if possible.
> 

Argl.

Why vmw_pvscsi? Any paravirtualized driver doesn't improve the situation
here; we still wouldn't have a driver for unmodified guests.
So either emulate existing drivers (like megasas :-) or go the full
route and do a proper virtio-scsi.

As for the bounce buffers thing:
Good luck. Paul Brook absolutely insists on having them, but they kill
performance for any sane backend. And both are basically impossible to
reconcile; tried it once but got pushed back.

And after about the third attempt I gave up. Let me know if you have
more luck here.

But keep me in the loop for the virtio-scsi spec. I do have some ideas
what needs to get in there.
As I think hch has.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke              zSeries & Storage
hare@suse.de                  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

  parent reply	other threads:[~2011-04-15 14:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 13:42 [Qemu-devel] [RFC PATCH] implement vmware pvscsi device Paolo Bonzini
2011-04-15 14:01 ` Stefan Hajnoczi
2011-04-15 14:17   ` Paolo Bonzini
2011-04-15 14:28     ` Stefan Hajnoczi
2011-04-15 14:37       ` Paolo Bonzini
2011-04-15 15:04         ` Stefan Hajnoczi
2011-04-15 20:56           ` Paolo Bonzini
2011-04-18 14:05             ` Hannes Reinecke
2011-04-18 15:27               ` Stefan Hajnoczi
2011-04-18 16:09               ` Paolo Bonzini
2011-04-15 14:55     ` Hannes Reinecke [this message]
2011-04-15 14:59       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA85C7E.6030403@suse.de \
    --to=hare@suse.de \
    --cc=mst@redhat.com \
    --cc=nab@linux-iscsi.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.