Re: [Qemu-devel] [RFC PATCH] implement vmware pvscsi device

[Paolo Bonzini <pbonzini@redhat.com>]

On 04/18/2011 04:05 PM, Hannes Reinecke wrote:
> My proposal would be to implement a full virtio-scsi _host_, and extend
> the proposal to be able to handle the transport layer too.

Yes, I have added this independently from Friday to today, and it is why 
I haven't sent the proposal yet.

> At the lastest we would need to include a LUN address before the CDB,
> and define TMF command values for proper error recovery.

I haven't yet worked out TMF, but I did add a LUN.

> That way we could handle hotplug / -unplug via a simple host rescan

It's a bit more complicated because you also want guest-initiated 
unplug, and SAM transport reset events include more than hotplug/unplug.

>> I couldn't find that in either SPC or SAM indeed. It seems like a
>> pretty widespread assumption though. Perhaps Nicholas or Hannes know
>> where it comes from.
>>
> 96 bytes is a carry-over from scsi parallel. We shouldn't rely
> on a fixed length here but rather use an additional pointer/iovec and
> length field.
>
> Check SG_IO header on how it's done.

Will do.

Paolo