All of lore.kernel.org
 help / color / mirror / Atom feed
From: Endres Puschner <code@e7p.de>
To: grub-devel@gnu.org
Subject: Icon Class Bug
Date: Mon, 18 Apr 2011 15:41:35 +0200	[thread overview]
Message-ID: <4DAC3F8F.6000007@e7p.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi grub-devel,

as it is better to send Bugs seperate to the features, I would send you 
the bug I fixed in "Horizontal boot menu" seperately now.

It is in the icon section. The first group in any menuentry was skipped 
while looking for icons before, so only icons for the second class would 
be searched.

Best regards,
   Endres

[-- Attachment #2: grub_bug_iconclass.diff --]
[-- Type: text/x-patch, Size: 433 bytes --]

=== modified file 'grub-core/gfxmenu/icon_manager.c'
--- grub-core/gfxmenu/icon_manager.c	2009-11-21 16:48:05 +0000
+++ grub-core/gfxmenu/icon_manager.c	2011-04-09 13:10:49 +0000
@@ -257,7 +257,7 @@
 
   /* Try each class in succession.  */
   icon = 0;
-  for (c = entry->classes->next; c && ! icon; c = c->next)
+  for (c = entry->classes; c && ! icon; c = c->next)
     icon = get_icon_by_class (mgr, c->name);
   return icon;
 }

             reply	other threads:[~2011-04-18 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18 13:41 Endres Puschner [this message]
2011-04-18 21:25 ` Icon Class Bug Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DAC3F8F.6000007@e7p.de \
    --to=code@e7p.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.