All of lore.kernel.org
 help / color / mirror / Atom feed
* Icon Class Bug
@ 2011-04-18 13:41 Endres Puschner
  2011-04-18 21:25 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 1 reply; 2+ messages in thread
From: Endres Puschner @ 2011-04-18 13:41 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Hi grub-devel,

as it is better to send Bugs seperate to the features, I would send you 
the bug I fixed in "Horizontal boot menu" seperately now.

It is in the icon section. The first group in any menuentry was skipped 
while looking for icons before, so only icons for the second class would 
be searched.

Best regards,
   Endres

[-- Attachment #2: grub_bug_iconclass.diff --]
[-- Type: text/x-patch, Size: 433 bytes --]

=== modified file 'grub-core/gfxmenu/icon_manager.c'
--- grub-core/gfxmenu/icon_manager.c	2009-11-21 16:48:05 +0000
+++ grub-core/gfxmenu/icon_manager.c	2011-04-09 13:10:49 +0000
@@ -257,7 +257,7 @@
 
   /* Try each class in succession.  */
   icon = 0;
-  for (c = entry->classes->next; c && ! icon; c = c->next)
+  for (c = entry->classes; c && ! icon; c = c->next)
     icon = get_icon_by_class (mgr, c->name);
   return icon;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Icon Class Bug
  2011-04-18 13:41 Icon Class Bug Endres Puschner
@ 2011-04-18 21:25 ` Vladimir 'φ-coder/phcoder' Serbinenko
  0 siblings, 0 replies; 2+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2011-04-18 21:25 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

On 18.04.2011 15:41, Endres Puschner wrote:
> Hi grub-devel,
>
> as it is better to send Bugs seperate to the features, I would send
> you the bug I fixed in "Horizontal boot menu" seperately now.
>
> It is in the icon section. The first group in any menuentry was
> skipped while looking for icons before, so only icons for the second
> class would be searched.
>
committed thanks. Nest time please include changelog entry.
> Best regards,
>   Endres
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-18 21:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-18 13:41 Icon Class Bug Endres Puschner
2011-04-18 21:25 ` Vladimir 'φ-coder/phcoder' Serbinenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.