From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
tglx@linutronix.de, mingo@elte.hu, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 2/3] x86, cpu: Clean up and unify the NOP selection infrastructure
Date: Mon, 18 Apr 2011 16:39:28 -0700 [thread overview]
Message-ID: <4DACCBB0.2060804@linux.intel.com> (raw)
In-Reply-To: <1303169476.7181.71.camel@gandalf.stny.rr.com>
On 04/18/2011 04:31 PM, Steven Rostedt wrote:
>
> Can we please add a comment to this. The original (above) was confusing
> enough, but at least it used asm() so it wasn't that bad to figure out.
> Or at least the asm() usage would trigger in one's mind to think "Damn!
> They chose to use 'asm', it must be some kind of nasty trick. Let's take
> a better look at WTF they are doing!".
>
> Now the use a normal character array actual makes this even more subtle.
OK... I never thought it was particularly subtle, but okay.
A much bigger issue with this particular patch is that the
__init{data,const}_or_module presumably needs to be removed from these
structures, right?
-hpa
next prev parent reply other threads:[~2011-04-18 23:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 22:35 [RFC PATCHSET] x86, cpu: Clean up and unify the NOP selection infrastructure H. Peter Anvin
2011-04-18 22:35 ` [PATCH 1/3] x86, percpu: Use ASM_NOP4 instead of hardcoding P6_NOP4 H. Peter Anvin
2011-04-19 1:01 ` [tip:x86/cpu] " tip-bot for H. Peter Anvin
2011-04-18 22:35 ` [PATCH 2/3] x86, cpu: Clean up and unify the NOP selection infrastructure H. Peter Anvin
2011-04-18 23:31 ` Steven Rostedt
2011-04-18 23:39 ` H. Peter Anvin [this message]
2011-04-18 23:58 ` Steven Rostedt
2011-04-19 1:01 ` [tip:x86/cpu] " tip-bot for H. Peter Anvin
2011-04-18 22:36 ` [PATCH 3/3] x86, cpu: Change NOP selection for certain Intel CPUs H. Peter Anvin
2011-04-18 23:34 ` Steven Rostedt
2011-04-19 1:02 ` [tip:x86/cpu] " tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DACCBB0.2060804@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.