From: "tip-bot for H. Peter Anvin" <hpa@linux.intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
fweisbec@gmail.com, rostedt@goodmis.org, tj@kernel.org,
tglx@linutronix.de, jbaron@redhat.com, hpa@linux.intel.com
Subject: [tip:x86/cpu] x86, cpu: Change NOP selection for certain Intel CPUs
Date: Tue, 19 Apr 2011 01:02:02 GMT [thread overview]
Message-ID: <tip-d8d9766c8c29f71c37bc4b74cc9fcf6a192c9bfd@git.kernel.org> (raw)
In-Reply-To: <1303166160-10315-4-git-send-email-hpa@linux.intel.com>
Commit-ID: d8d9766c8c29f71c37bc4b74cc9fcf6a192c9bfd
Gitweb: http://git.kernel.org/tip/d8d9766c8c29f71c37bc4b74cc9fcf6a192c9bfd
Author: H. Peter Anvin <hpa@linux.intel.com>
AuthorDate: Mon, 18 Apr 2011 15:31:57 -0700
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Mon, 18 Apr 2011 16:40:32 -0700
x86, cpu: Change NOP selection for certain Intel CPUs
Due to a decoder implementation quirk, some specific Intel CPUs
actually perform better with the "k8_nops" than with the
SDM-recommended NOPs. For runtime-selected NOPs, if we detect those
specific CPUs then use the k8_nops instead of the ones we would
normally use.
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jason Baron <jbaron@redhat.com>
Link: http://lkml.kernel.org/r/1303166160-10315-4-git-send-email-hpa@linux.intel.com
---
arch/x86/kernel/alternative.c | 14 +++++++++++++-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 846f61e..c0501ea 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -199,7 +199,19 @@ void __init arch_init_ideal_nops(void)
{
switch (boot_cpu_data.x86_vendor) {
case X86_VENDOR_INTEL:
- if (boot_cpu_has(X86_FEATURE_NOPL)) {
+ /*
+ * Due to a decoder implementation quirk, some
+ * specific Intel CPUs actually perform better with
+ * the "k8_nops" than with the SDM-recommended NOPs.
+ */
+ if (boot_cpu_data.x86 == 6 &&
+ boot_cpu_data.x86_model >= 0x0f &&
+ boot_cpu_data.x86_model != 0x1c &&
+ boot_cpu_data.x86_model != 0x26 &&
+ boot_cpu_data.x86_model != 0x27 &&
+ boot_cpu_data.x86_model < 0x30) {
+ ideal_nops = k8_nops;
+ } else if (boot_cpu_has(X86_FEATURE_NOPL)) {
ideal_nops = p6_nops;
} else {
#ifdef CONFIG_X86_64
prev parent reply other threads:[~2011-04-19 1:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 22:35 [RFC PATCHSET] x86, cpu: Clean up and unify the NOP selection infrastructure H. Peter Anvin
2011-04-18 22:35 ` [PATCH 1/3] x86, percpu: Use ASM_NOP4 instead of hardcoding P6_NOP4 H. Peter Anvin
2011-04-19 1:01 ` [tip:x86/cpu] " tip-bot for H. Peter Anvin
2011-04-18 22:35 ` [PATCH 2/3] x86, cpu: Clean up and unify the NOP selection infrastructure H. Peter Anvin
2011-04-18 23:31 ` Steven Rostedt
2011-04-18 23:39 ` H. Peter Anvin
2011-04-18 23:58 ` Steven Rostedt
2011-04-19 1:01 ` [tip:x86/cpu] " tip-bot for H. Peter Anvin
2011-04-18 22:36 ` [PATCH 3/3] x86, cpu: Change NOP selection for certain Intel CPUs H. Peter Anvin
2011-04-18 23:34 ` Steven Rostedt
2011-04-19 1:02 ` tip-bot for H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-d8d9766c8c29f71c37bc4b74cc9fcf6a192c9bfd@git.kernel.org \
--to=hpa@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.