From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
lksctp <linux-sctp@vger.kernel.org>
Subject: [PATCH net-next-2.6 2/8] sctp: fix the comment of sctp_sf_violation_paramlen()
Date: Tue, 19 Apr 2011 05:11:01 +0000 [thread overview]
Message-ID: <4DAD1965.7090100@cn.fujitsu.com> (raw)
In-Reply-To: <4DAD18AB.3040401@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Update the comment about sctp_sf_violation_paramlen() to be
more precise.
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/sm_statefuns.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index 7679208..c085472 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -4343,8 +4343,9 @@ static sctp_disposition_t sctp_sf_violation_chunklen(
/*
* Handle a protocol violation when the parameter length is invalid.
- * "Invalid" length is identified as smaller than the minimal length a
- * given parameter can be.
+ * If the length is smaller than the minimum length of a given parameter,
+ * or accumulated length in multi parameters exceeds the end of the chunk,
+ * the length is considered as invalid.
*/
static sctp_disposition_t sctp_sf_violation_paramlen(
const struct sctp_endpoint *ep,
--
1.6.5.2
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
lksctp <linux-sctp@vger.kernel.org>
Subject: [PATCH net-next-2.6 2/8] sctp: fix the comment of sctp_sf_violation_paramlen()
Date: Tue, 19 Apr 2011 13:11:01 +0800 [thread overview]
Message-ID: <4DAD1965.7090100@cn.fujitsu.com> (raw)
In-Reply-To: <4DAD18AB.3040401@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Update the comment about sctp_sf_violation_paramlen() to be
more precise.
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/sctp/sm_statefuns.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index 7679208..c085472 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -4343,8 +4343,9 @@ static sctp_disposition_t sctp_sf_violation_chunklen(
/*
* Handle a protocol violation when the parameter length is invalid.
- * "Invalid" length is identified as smaller than the minimal length a
- * given parameter can be.
+ * If the length is smaller than the minimum length of a given parameter,
+ * or accumulated length in multi parameters exceeds the end of the chunk,
+ * the length is considered as invalid.
*/
static sctp_disposition_t sctp_sf_violation_paramlen(
const struct sctp_endpoint *ep,
--
1.6.5.2
next prev parent reply other threads:[~2011-04-19 5:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 5:07 [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for add/del Wei Yongjun
2011-04-19 5:07 ` [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for add/del ip Wei Yongjun
2011-04-19 5:09 ` [PATCH net-next-2.6 1/8] sctp: delete unused macro definition of Wei Yongjun
2011-04-19 5:09 ` [PATCH net-next-2.6 1/8] sctp: delete unused macro definition of sctp_chunk_is_control Wei Yongjun
2011-04-19 5:19 ` [PATCH net-next-2.6 1/8 v2] sctp: delete unused macro definition Wei Yongjun
2011-04-19 5:19 ` [PATCH net-next-2.6 1/8 v2] sctp: delete unused macro definition of sctp_chunk_is_control Wei Yongjun
2011-04-20 4:47 ` [PATCH net-next-2.6 1/8 v2] sctp: delete unused macro David Miller
2011-04-20 4:47 ` [PATCH net-next-2.6 1/8 v2] sctp: delete unused macro definition of sctp_chunk_is_control David Miller
2011-04-19 5:11 ` Wei Yongjun [this message]
2011-04-19 5:11 ` [PATCH net-next-2.6 2/8] sctp: fix the comment of sctp_sf_violation_paramlen() Wei Yongjun
2011-04-20 4:47 ` [PATCH net-next-2.6 2/8] sctp: fix the comment of David Miller
2011-04-20 4:47 ` [PATCH net-next-2.6 2/8] sctp: fix the comment of sctp_sf_violation_paramlen() David Miller
2011-04-19 5:11 ` [PATCH net-next-2.6 3/8] sctp: use common head of addr parameter Wei Yongjun
2011-04-19 5:11 ` [PATCH net-next-2.6 3/8] sctp: use common head of addr parameter to access member in addr-unrelated code Wei Yongjun
2011-04-20 4:47 ` [PATCH net-next-2.6 3/8] sctp: use common head of addr David Miller
2011-04-20 4:47 ` [PATCH net-next-2.6 3/8] sctp: use common head of addr parameter to access member in addr-unrelated code David Miller
2011-04-19 5:12 ` [PATCH net-next-2.6 4/8] sctp: kill abandoned SCTP_CMD_TRANSMIT command Wei Yongjun
2011-04-19 5:12 ` Wei Yongjun
2011-04-20 4:47 ` [PATCH net-next-2.6 4/8] sctp: kill abandoned David Miller
2011-04-20 4:47 ` [PATCH net-next-2.6 4/8] sctp: kill abandoned SCTP_CMD_TRANSMIT command David Miller
2011-04-19 5:13 ` [PATCH net-next-2.6 5/8] sctp: use memdup_user to copy data from Wei Yongjun
2011-04-19 5:13 ` [PATCH net-next-2.6 5/8] sctp: use memdup_user to copy data from userspace Wei Yongjun
2011-04-20 4:47 ` [PATCH net-next-2.6 5/8] sctp: use memdup_user to copy data David Miller
2011-04-20 4:47 ` [PATCH net-next-2.6 5/8] sctp: use memdup_user to copy data from userspace David Miller
2011-04-19 5:13 ` [PATCH net-next-2.6 6/8] sctp: teach CACC algorithm about removed Wei Yongjun
2011-04-19 5:13 ` [PATCH net-next-2.6 6/8] sctp: teach CACC algorithm about removed transports Wei Yongjun
2011-04-20 4:47 ` [PATCH net-next-2.6 6/8] sctp: teach CACC algorithm about David Miller
2011-04-20 4:47 ` [PATCH net-next-2.6 6/8] sctp: teach CACC algorithm about removed transports David Miller
2011-04-19 5:14 ` [PATCH net-next-2.6 7/8] sctp: Allow bindx_del to accept 0 port Wei Yongjun
2011-04-19 5:14 ` Wei Yongjun
2011-04-20 4:47 ` David Miller
2011-04-20 4:47 ` David Miller
2011-04-19 5:15 ` [PATCH net-next-2.6 8/8] sctp: Release all routes when processing Wei Yongjun
2011-04-19 5:15 ` [PATCH net-next-2.6 8/8] sctp: Release all routes when processing acks ADD_IP or DEL_IP Wei Yongjun
2011-04-20 4:47 ` [PATCH net-next-2.6 8/8] sctp: Release all routes when David Miller
2011-04-20 4:47 ` [PATCH net-next-2.6 8/8] sctp: Release all routes when processing acks ADD_IP or DEL_IP David Miller
2011-04-19 5:31 ` [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for Shan Wei
2011-04-19 5:31 ` [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for add/del ip Shan Wei
2011-04-19 8:10 ` [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for Nicolas Dichtel
2011-04-19 8:10 ` [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for add/del ip Nicolas Dichtel
2011-04-19 8:18 ` [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for Wei Yongjun
2011-04-19 8:18 ` [PATCH net-next-2.6 0/8] sctp: some cleanup and tiny fix for add/del ip Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD1965.7090100@cn.fujitsu.com \
--to=yjwei@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.