Re: [RFC] [PATCH 2/2] pkgconfig: add git version

[Andreas Oberritter <obi@opendreambox.org>]

On 04/18/2011 03:50 PM, Paul Menzel wrote:
> Date: Sun, 17 Apr 2011 19:19:58 +0200
> 
> 1. The revision is close to the upcoming release of pkg-config 0.26. [1]
> 2. The patch `sysrootfix.patch` has been merged upstream [2].
> 3. No embedded GLib is shipped anymore [3]. Therefore drop patches `autofoo.patch` and `glibconfig-sysdefs.h`.
> 
> The patch is tested using the following configuration
> 
> 	Build Configuration:
> 	BB_VERSION        = "1.12.0"
> 	METADATA_BRANCH   = "pkg-config"
> 	METADATA_REVISION = "d4ae0c5"
> 	TARGET_ARCH       = "arm"
> 	TARGET_OS         = "linux-uclibceabi"
> 	MACHINE           = "beagleboard"
> 	DISTRO            = "minimal-uclibc"
> 	DISTRO_VERSION    = "dev-snapshot-20110417"
> 	TARGET_FPU        = "hard"
> 
> and `angstrom-2010.x` and `minimal` too.
> 
> [1] http://lists.freedesktop.org/archives/pkg-config/2011-April/000720.html
> [2] http://cgit.freedesktop.org/pkg-config/commit/?id=66d49f1375fec838bcd301bb4ca2ef76cee0e47c
> [3] http://cgit.freedesktop.org/pkg-config/commit/?id=99964eddb5935173fcedfc793e762d7dc7d01bba
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> 1. How can this recipe used also for the native recipe?
> 2. What is `pkg-config-sdk` used for?
> ---
>  recipes/pkgconfig/pkgconfig_git.bb |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/pkgconfig/pkgconfig_git.bb
> 
> diff --git a/recipes/pkgconfig/pkgconfig_git.bb b/recipes/pkgconfig/pkgconfig_git.bb
> new file mode 100644
> index 0000000..9c6d7d1
> --- /dev/null
> +++ b/recipes/pkgconfig/pkgconfig_git.bb
> @@ -0,0 +1,12 @@
> +require ${PN}.inc
> +
> +PR = "${INC_PR}.0"
> +
> +SRCREV = "7850aeb03a54a15d07b6c243b61033cd379c39d7"
> +SRC_URI = "git://anongit.freedesktop.org/pkg-config;protocol=git"
> +
> +PV = "0.26"
> +PR = "${INC_PR}.0"
> +PR_append = "+gitr${SRCPV}"

Usually, SRCPV is used in PV, not PR. Also, I'd prefer not using 0.26
for a pre-release snapshot, to make a future update to the released
version work. How about using one of

PV = "0.25+gitr${SRCPV}"

or

PV = "0.25.999+gitr${SRCPV}"

instead, and removing the PR_append line?

Regards,
Andreas