Re: [RFC] [PATCH 2/2] pkgconfig: add git version

[Andreas Oberritter <obi@opendreambox.org>]

On 05/15/2011 06:24 PM, Paul Menzel wrote:
> Am Samstag, den 23.04.2011, 10:02 +0200 schrieb Koen Kooi:
> 
>> On 23-04-11 00:00, Paul Menzel wrote:
>>> Date: Sun, 17 Apr 2011 19:19:58 +0200
>>>
>>> 1. The revision is close to the upcoming release of pkg-config 0.26. [1]
>>> 2. The patch `sysrootfix.patch` has been merged upstream [2].
>>> 3. No embedded GLib is shipped anymore [3]. Therefore drop patches `autofoo.patch` and `glibconfig-sysdefs.h`.
>>>
>>> The patch is tested using the following configuration
>>>
>>> 	Build Configuration:
>>> 	BB_VERSION        = "1.12.0"
>>> 	METADATA_BRANCH   = "pkg-config"
>>> 	METADATA_REVISION = "d4ae0c5"
>>> 	TARGET_ARCH       = "arm"
>>> 	TARGET_OS         = "linux-uclibceabi"
>>> 	MACHINE           = "beagleboard"
>>> 	DISTRO            = "minimal-uclibc"
>>> 	DISTRO_VERSION    = "dev-snapshot-20110417"
>>> 	TARGET_FPU        = "hard"
>>>
>>> and `angstrom-2010.x` and `minimal` too.
>>>
>>> [1] http://lists.freedesktop.org/archives/pkg-config/2011-April/000720.html
>>> [2] http://cgit.freedesktop.org/pkg-config/commit/?id=66d49f1375fec838bcd301bb4ca2ef76cee0e47c
>>> [3] http://cgit.freedesktop.org/pkg-config/commit/?id=99964eddb5935173fcedfc793e762d7dc7d01bba
>>>
>>> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
>>
>> Acked-by: Koen Kooi <koen@dominion.thruhere.net>
> 
> I did not commit this yet thinking Andreas would give his ack.

I still think that using SRCPV in PR is just wrong. SRCPV doesn't change
the version of the package but the version of the packaged content.
Otherwise it would be called SRCPR.

>>> +PV = "0.25+0.26"
>>> +PR = "${INC_PR}.0"
>>> +PR_append = "+gitr${SRCPV}"

Regards,
Andreas