From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 2/5] ath9k_htc: Fix AMPDU subframe handling
Date: Wed, 20 Apr 2011 11:20:41 +0300 [thread overview]
Message-ID: <4DAE9759.9020005@gmail.com> (raw)
In-Reply-To: <19886.28554.581823.283614@gargle.gargle.HOWL>
On 04/20/2011 08:30 AM, Sujith wrote:
> From: Sujith Manoharan<Sujith.Manoharan@atheros.com>
>
> * Register the driver's maximum ampdu subframe limit to mac80211.
> * Cleanup the target capabilities structure and fix an endian issue.
> * Fix BTCOEX by sending a command to the target when the BT priority
> changes.
> * Bump the required firmware version to 1.1
>
> Signed-off-by: Sujith Manoharan<Sujith.Manoharan@atheros.com>
[...]
> + /*
> + * Check if the available FW matches the driver's
> + * required version.
> + */
> + if (priv->fw_version_major< MAJOR_VERSION_REQ ||
> + priv->fw_version_minor< MINOR_VERSION_REQ) {
Wrong version check logic. Version 2.0 will fail this 1.1 check, because
of minor version number.
Should be something like:
if (priv->fw_version_major < MAJOR_VERSION_REQ ||
(priv->fw_version_major == MAJOR_VERSION_REQ &&
priv->fw_version_minor < MINOR_VERSION_REQ))
> + dev_err(priv->dev, "ath9k_htc: Please upgrade to FW version %d.%d\n",
> + MAJOR_VERSION_REQ, MINOR_VERSION_REQ);
> + return -EINVAL;
> + }
> +
> return 0;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: Sujith <public-m.sujith-Re5JQEeQqe8AvxtiuMwx3w@plane.gmane.org>
Cc: public-linville-2XuSBdqkA4R54TAoqtyWWQ@plane.gmane.org,
public-linux-wireless-u79uwXL29TY76Z2rM5mHXA@plane.gmane.org,
public-ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@plane.gmane.org
Subject: Re: [PATCH 2/5] ath9k_htc: Fix AMPDU subframe handling
Date: Wed, 20 Apr 2011 11:20:41 +0300 [thread overview]
Message-ID: <4DAE9759.9020005@gmail.com> (raw)
In-Reply-To: <19886.28554.581823.283614@gargle.gargle.HOWL>
On 04/20/2011 08:30 AM, Sujith wrote:
> From: Sujith Manoharan<Sujith.Manoharan-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>
>
> * Register the driver's maximum ampdu subframe limit to mac80211.
> * Cleanup the target capabilities structure and fix an endian issue.
> * Fix BTCOEX by sending a command to the target when the BT priority
> changes.
> * Bump the required firmware version to 1.1
>
> Signed-off-by: Sujith Manoharan<Sujith.Manoharan-DlyHzToyqoxBDgjK7y7TUQ@public.gmane.org>
[...]
> + /*
> + * Check if the available FW matches the driver's
> + * required version.
> + */
> + if (priv->fw_version_major< MAJOR_VERSION_REQ ||
> + priv->fw_version_minor< MINOR_VERSION_REQ) {
Wrong version check logic. Version 2.0 will fail this 1.1 check, because
of minor version number.
Should be something like:
if (priv->fw_version_major < MAJOR_VERSION_REQ ||
(priv->fw_version_major == MAJOR_VERSION_REQ &&
priv->fw_version_minor < MINOR_VERSION_REQ))
> + dev_err(priv->dev, "ath9k_htc: Please upgrade to FW version %d.%d\n",
> + MAJOR_VERSION_REQ, MINOR_VERSION_REQ);
> + return -EINVAL;
> + }
> +
> return 0;
> }
next prev parent reply other threads:[~2011-04-20 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 5:30 [ath9k-devel] [PATCH 2/5] ath9k_htc: Fix AMPDU subframe handling Sujith
2011-04-20 5:30 ` Sujith
2011-04-20 8:20 ` Paulius Zaleckas [this message]
2011-04-20 8:20 ` Paulius Zaleckas
2011-04-20 8:54 ` [ath9k-devel] " Sujith
2011-04-20 8:54 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAE9759.9020005@gmail.com \
--to=paulius.zaleckas@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.