From: Jan Kiszka <jan.kiszka@siemens.com>
To: Yaniv Kaul <ykaul@redhat.com>
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: Failure to compile latest git (target-i386/kvm.c:953:29: error: variable ‘fop’ set but not used)
Date: Thu, 21 Apr 2011 17:43:02 +0200 [thread overview]
Message-ID: <4DB05086.7050609@siemens.com> (raw)
In-Reply-To: <4DB03AC4.1070907@redhat.com>
On 2011-04-21 16:10, Yaniv Kaul wrote:
> Fedora 15beta/x64, latest git:
> [ykaul@ykaul qemu]$ make
> CC x86_64-softmmu/kvm.o
> /home/ykaul/qemu/target-i386/kvm.c: In function ‘kvm_get_xsave’:
> /home/ykaul/qemu/target-i386/kvm.c:953:29: error: variable ‘fop’ set but
> not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> make[1]: *** [kvm.o] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
>
This one looks a bit suspicious:
Avi, why do we have kvm_fpu::last_* in the ABI, copying that information
from/to user land, but do not handle it otherwise? To my understanding
this fop here in xsave corresponds to kvm_fpu::last_opcode in the
SET/GET_FPU case, right? It's set to 0 on SET_XSAVE and ignored on
GET_XSAVE as this warnings tells us.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Yaniv Kaul <ykaul@redhat.com>
Cc: qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] Failure to compile latest git (target-i386/kvm.c:953:29: error: variable ‘fop’ set but not used)
Date: Thu, 21 Apr 2011 17:43:02 +0200 [thread overview]
Message-ID: <4DB05086.7050609@siemens.com> (raw)
In-Reply-To: <4DB03AC4.1070907@redhat.com>
On 2011-04-21 16:10, Yaniv Kaul wrote:
> Fedora 15beta/x64, latest git:
> [ykaul@ykaul qemu]$ make
> CC x86_64-softmmu/kvm.o
> /home/ykaul/qemu/target-i386/kvm.c: In function ‘kvm_get_xsave’:
> /home/ykaul/qemu/target-i386/kvm.c:953:29: error: variable ‘fop’ set but
> not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
>
> make[1]: *** [kvm.o] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
>
This one looks a bit suspicious:
Avi, why do we have kvm_fpu::last_* in the ABI, copying that information
from/to user land, but do not handle it otherwise? To my understanding
this fop here in xsave corresponds to kvm_fpu::last_opcode in the
SET/GET_FPU case, right? It's set to 0 on SET_XSAVE and ignored on
GET_XSAVE as this warnings tells us.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-04-21 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 14:10 [Qemu-devel] Failure to compile latest git (target-i386/kvm.c:953:29: error: variable ‘fop’ set but not used) Yaniv Kaul
2011-04-21 15:12 ` Stefan Hajnoczi
2011-04-21 15:43 ` Jan Kiszka [this message]
2011-04-21 15:43 ` Jan Kiszka
2011-04-24 7:10 ` Avi Kivity
2011-04-24 7:10 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB05086.7050609@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ykaul@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.