[PATCH] Ralink 3090 must load rt3090.bin firmware, not rt2860.bin.

[PATCH] Ralink 3090 must load rt3090.bin firmware, not rt2860.bin.

[Catalin(ux) M. BOIE]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 119 bytes --]

Hello.

Please apply it.
Thank you!

P.S. Please keep me in To/CC.

--
Catalin(ux) M. BOIE
http://kernel.embedromix.ro/

[-- Attachment #2: Type: TEXT/PLAIN, Size: 1580 bytes --]

From cf0c7999f1620bb5dfbacfd83cecaa3cb69a1897 Mon Sep 17 00:00:00 2001
From: Catalin(ux) M. BOIE <catab@embedromix.ro>
Date: Wed, 20 Apr 2011 23:32:18 +0300
Subject: [PATCH] Ralink 3090 must load rt3090.bin firmware, not rt2860.bin.

rt2860.bin is working, I can get a link, but the led flashes continuously;
rt2860.bin is version 0.11, rt3090.bin is version 0.19.
I transfered a lot of data and is stable.

Signed-off-by: Catalin(ux) M. BOIE <catab@embedromix.ro>
---
 drivers/net/wireless/rt2x00/rt2800pci.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
index 808073a..01745e3 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -282,7 +282,13 @@ static void rt2800pci_stop_queue(struct data_queue *queue)
  */
 static char *rt2800pci_get_firmware_name(struct rt2x00_dev *rt2x00dev)
 {
-	return FIRMWARE_RT2860;
+	switch (rt2x00dev->chip.rt) {
+	case RT3090:
+		return "rt3090.bin";
+
+	default:
+		return FIRMWARE_RT2860;
+	}
 }
 
 static int rt2800pci_write_firmware(struct rt2x00_dev *rt2x00dev,
@@ -1146,6 +1152,7 @@ MODULE_DESCRIPTION("Ralink RT2800 PCI & PCMCIA Wireless LAN driver.");
 MODULE_SUPPORTED_DEVICE("Ralink RT2860 PCI & PCMCIA chipset based cards");
 #ifdef CONFIG_PCI
 MODULE_FIRMWARE(FIRMWARE_RT2860);
+MODULE_FIRMWARE("rt3090.bin");
 MODULE_DEVICE_TABLE(pci, rt2800pci_device_table);
 #endif /* CONFIG_PCI */
 MODULE_LICENSE("GPL");
-- 
1.7.4.4

Re: [PATCH] Ralink 3090 must load rt3090.bin firmware, not rt2860.bin.

[Ivo Van Doorn]

Hi,

On Thu, Apr 21, 2011 at 9:25 PM, Catalin(ux) M. BOIE
<catab@embedromix.ro> wrote:
> Hello.
>
> Please apply it.

NACK.

1) You didn't send this patch inline
2) There is no such thing as different firmware filenames
for the rt2800pci drivers. Ralink did release some stuff under different names,
but they are basically different versions of the same file.

So you can rename your rt3090.bin file to rt2860.bin file, and both rt2860 and
rt3090 devices can operate using it.

Ivo

Re: [PATCH] Ralink 3090 must load rt3090.bin firmware, not rt2860.bin.

[Larry Finger]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

On 04/21/2011 02:25 PM, Catalin(ux) M. BOIE wrote:
> Hello.
>
> Please apply it.
> Thank you!
>
> P.S. Please keep me in To/CC.
>
> --
> Catalin(ux) M. BOIE
> http://kernel.embedromix.ro/

NACK. That version of rt2860.bin is really old.

Please remove your patch and try with the attached version of rt2860.bin. It is 
version 29.

Larry

[-- Attachment #2: rt2860.bin --]
[-- Type: application/octet-stream, Size: 8192 bytes --]

Re: [PATCH] Ralink 3090 must load rt3090.bin firmware, not rt2860.bin.

[Catalin(ux) M. BOIE]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 739 bytes --]

On Thu, 21 Apr 2011, Larry Finger wrote:

> On 04/21/2011 02:25 PM, Catalin(ux) M. BOIE wrote:
>> Hello.
>> 
>> Please apply it.
>> Thank you!

Hello.

(David added to CC)

> NACK. That version of rt2860.bin is really old.
>
> Please remove your patch and try with the attached version of 
rt2860.bin. It
> is version 29.
>
> Larry

Larry, Ivo, thank you for your time.

rt3090.bin comes with linux-firmware package in my Fedora 14.
In Fedora 15 Beta seems to be the same version (20110304).
So, they are not up-to-date.

The plan:
1. Remove rt3090.bin from linux-firmware because is confusing.
2. Update linux-firmware's rt2860.bin to Larry's (attached) version.

Does everybody agree?

--
Catalin(ux) M. BOIE
http://kernel.embedromix.ro/

[-- Attachment #2: Type: APPLICATION/OCTET-STREAM, Size: 8192 bytes --]

Re: [PATCH] Ralink 3090 must load rt3090.bin firmware, not rt2860.bin.

[Ivo Van Doorn]

Hi,

> Larry, Ivo, thank you for your time.
>
> rt3090.bin comes with linux-firmware package in my Fedora 14.
> In Fedora 15 Beta seems to be the same version (20110304).
> So, they are not up-to-date.

There is already a discussion on linux-wireless regarding this.
Unfortunately all previous attempts to upgrade the firmware seems to
have failed.
Last week a new patch was send, so hopefully that will be applied.

> The plan:
> 1. Remove rt3090.bin from linux-firmware because is confusing.
> 2. Update linux-firmware's rt2860.bin to Larry's (attached) version.

I agree with 1, but unfortunately the policy of linux-firmware is that
the firmware cannot be removed when a driver exists which uses it
(regardless of the presence of that driver inside the latest
linux-kernel release).

I also agree with 2, but that apparently is quite hard. Multiple people
have send patches, I hope that the last attempt of last week will be
accepted and applied.

Ivo