* [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647
@ 2011-04-21 18:35 Sam Ravnborg
2011-04-21 22:48 ` [PATCH revised v2] sparc32: avoid build warning at David Miller
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sam Ravnborg @ 2011-04-21 18:35 UTC (permalink / raw)
To: sparclinux
Fix following warning:
mm/percpu.c: In function 'pcpu_embed_first_chunk':
mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
[sam: added warning message to changelog, use _AC()]
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
Use _AC() as pointed out.
Build tested.
Sam
diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h
index 303bd4d..5b31a8e 100644
--- a/arch/sparc/include/asm/pgtable_32.h
+++ b/arch/sparc/include/asm/pgtable_32.h
@@ -8,6 +8,8 @@
* Copyright (C) 1998 Jakub Jelinek (jj@sunsite.mff.cuni.cz)
*/
+#include <linux/const.h>
+
#ifndef __ASSEMBLY__
#include <asm-generic/4level-fixup.h>
@@ -456,9 +458,9 @@ extern int io_remap_pfn_range(struct vm_area_struct *vma,
#endif /* !(__ASSEMBLY__) */
-#define VMALLOC_START 0xfe600000
+#define VMALLOC_START _AC(0xfe600000,UL)
/* XXX Alter this when I get around to fixing sun4c - Anton */
-#define VMALLOC_END 0xffc00000
+#define VMALLOC_END _AC(0xffc00000,UL)
/* We provide our own get_unmapped_area to cope with VA holes for userland */
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH revised v2] sparc32: avoid build warning at
2011-04-21 18:35 [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647 Sam Ravnborg
@ 2011-04-21 22:48 ` David Miller
2011-04-22 7:41 ` Sam Ravnborg
2011-04-22 8:17 ` [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-04-21 22:48 UTC (permalink / raw)
To: sparclinux
From: Sam Ravnborg <sam@ravnborg.org>
Date: Thu, 21 Apr 2011 20:35:56 +0200
> Fix following warning:
>
> mm/percpu.c: In function 'pcpu_embed_first_chunk':
> mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
>
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> [sam: added warning message to changelog, use _AC()]
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Applied to sparc-next-2.6, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH revised v2] sparc32: avoid build warning at
2011-04-21 18:35 [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647 Sam Ravnborg
2011-04-21 22:48 ` [PATCH revised v2] sparc32: avoid build warning at David Miller
@ 2011-04-22 7:41 ` Sam Ravnborg
2011-04-22 8:17 ` [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
2 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2011-04-22 7:41 UTC (permalink / raw)
To: sparclinux
On Thu, Apr 21, 2011 at 03:48:49PM -0700, David Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Thu, 21 Apr 2011 20:35:56 +0200
>
> > Fix following warning:
> >
> > mm/percpu.c: In function 'pcpu_embed_first_chunk':
> > mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
> >
> > Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> > [sam: added warning message to changelog, use _AC()]
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>
> Applied to sparc-next-2.6, thanks.
I screwed up author-ship on this one - Daniel was the original author.
But I guess Daniel and I can fix this over a beer if we meet someday.
Will try to be more carefull in the future!
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647
2011-04-21 18:35 [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647 Sam Ravnborg
2011-04-21 22:48 ` [PATCH revised v2] sparc32: avoid build warning at David Miller
2011-04-22 7:41 ` Sam Ravnborg
@ 2011-04-22 8:17 ` Daniel Hellstrom
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Hellstrom @ 2011-04-22 8:17 UTC (permalink / raw)
To: sparclinux
Sam Ravnborg wrote:
>On Thu, Apr 21, 2011 at 03:48:49PM -0700, David Miller wrote:
>
>
>>From: Sam Ravnborg <sam@ravnborg.org>
>>Date: Thu, 21 Apr 2011 20:35:56 +0200
>>
>>
>>
>>>Fix following warning:
>>>
>>>mm/percpu.c: In function 'pcpu_embed_first_chunk':
>>>mm/percpu.c:1647:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'unsigned int'
>>>
>>>Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
>>>[sam: added warning message to changelog, use _AC()]
>>>Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>>>
>>>
>>Applied to sparc-next-2.6, thanks.
>>
>>
>
>I screwed up author-ship on this one - Daniel was the original author.
>But I guess Daniel and I can fix this over a beer if we meet someday.
>Will try to be more carefull in the future!
>
>
I think we have to meet in Germany in order to get a big beer enough to
compensate for that... :) by the way thanks for cleaning up the patch
for me.
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-04-22 8:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-21 18:35 [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647 Sam Ravnborg
2011-04-21 22:48 ` [PATCH revised v2] sparc32: avoid build warning at David Miller
2011-04-22 7:41 ` Sam Ravnborg
2011-04-22 8:17 ` [PATCH revised v2] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.