[PATCH 1/2] Fix ofonod crash issue

[PATCH 1/2] Fix ofonod crash issue

[martin.xu]

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

From: Martin Xu <martin.xu@intel.com>

In case of offline modem when GPRS data connection is connected, if gprs
atom is removed before PPP termination process is complete, the terminate_timer
will not be stop. It will cause ofonod crash when the timer time out.
---
 gatchat/ppp_cp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
index f0731cc..6e4a9c5 100644
--- a/gatchat/ppp_cp.c
+++ b/gatchat/ppp_cp.c
@@ -970,6 +970,8 @@ void pppcp_process_packet(gpointer priv, const guint8 *new_packet)
 
 void pppcp_free(struct pppcp_data *pppcp)
 {
+	pppcp_stop_timer(&pppcp->config_timer_data);
+	pppcp_stop_timer(&pppcp->terminate_timer_data);
 	g_free(pppcp->peer_options);
 	g_free(pppcp);
 }
-- 
1.7.2.2

Re: [PATCH 1/2] Fix ofonod crash issue

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi Martin,

On 04/26/2011 04:07 AM, martin.xu(a)intel.com wrote:
> From: Martin Xu <martin.xu@intel.com>
> 
> In case of offline modem when GPRS data connection is connected, if gprs
> atom is removed before PPP termination process is complete, the terminate_timer
> will not be stop. It will cause ofonod crash when the timer time out.
> ---
>  gatchat/ppp_cp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 

I fixed up the commit message slightly and applied this patch.  Thanks
for that.

Regards,
-Denis