From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.
Date: Wed, 27 Apr 2011 17:05:54 +0200 [thread overview]
Message-ID: <4DB830D2.7010706@redhat.com> (raw)
In-Reply-To: <20110427120520.74e348d9@doriath>
On 04/27/11 17:05, Luiz Capitulino wrote:
> On Mon, 18 Apr 2011 16:27:01 +0200
> Jes.Sorensen@redhat.com wrote:
>
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This is quivalent to snapshot_blkdev in the human monitor, with _sync
>> added to the command name to make it explicit that the command is
>> synchronous and leave space for a future async version.
>
> I'm not sure appending "_sync" is such a good convention, most commands
> are sync today and they don't have it. I'd prefer to call it snapshot_blkdev
> and note in the documentation how it works.
>
> On the other hand, I'm not sure how Anthony is going to model async
> commands, so maybe he has a better suggestion.
The _sync prefix is on purpose to leave space for a possible async
implementation of the snapshot command in the future. This isn't related
to it being a sync vs async qmp command though.
Jes
next prev parent reply other threads:[~2011-04-27 15:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 14:27 [Qemu-devel] [PATCH v2 0/1] Add QMP bits for blockdev-snapshot-sync Jes.Sorensen
2011-04-18 14:27 ` [Qemu-devel] [PATCH v2 1/1] " Jes.Sorensen
2011-04-27 15:05 ` Luiz Capitulino
2011-04-27 15:05 ` Jes Sorensen [this message]
2011-04-28 12:45 ` Jes Sorensen
2011-04-28 13:14 ` Jes Sorensen
2011-04-28 13:21 ` Jes Sorensen
2011-04-28 13:41 ` Kevin Wolf
2011-04-28 13:46 ` Jes Sorensen
2011-04-28 14:42 ` Kevin Wolf
2011-04-28 14:41 ` Jes Sorensen
2011-04-28 14:21 ` Luiz Capitulino
2011-04-28 14:30 ` Jes Sorensen
2011-04-28 14:38 ` Anthony Liguori
2011-04-28 14:36 ` Anthony Liguori
2011-04-28 14:38 ` Jes Sorensen
2011-04-28 14:46 ` Anthony Liguori
2011-04-28 14:57 ` Jes Sorensen
2011-04-28 15:10 ` Anthony Liguori
2011-04-29 13:38 ` Jes Sorensen
2011-04-29 13:45 ` Anthony Liguori
2011-05-03 11:44 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB830D2.7010706@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.