All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.
Date: Thu, 28 Apr 2011 16:42:20 +0200	[thread overview]
Message-ID: <4DB97CCC.2010601@redhat.com> (raw)
In-Reply-To: <4DB96FA9.5000202@redhat.com>

Am 28.04.2011 15:46, schrieb Jes Sorensen:
> On 04/28/11 15:41, Kevin Wolf wrote:
>>>> Finally, what's the expect behavior when -snapshot is used? I'm getting
>>>>>> this:
>>>>>>
>>>>>>  (qemu) snapshot_blkdev ide0-hd0 snap-test
>>>>>>  Could not open '/tmp/vl.6w8YXA'
>>>>>>  (qemu)
>>>>
>>>> What type of file system is your /tmp? You need to provide full path to
>>>> the snapshot file if you don't want it created next to where your qemu
>>>> binary is being executed.
>> I think the problem is that this is a temporary file, i.e. unlinked
>> directly after it has been opened. Trying to reopen a deleted file is a
>> bad idea.
> 
> True, but if /tmp is tmpfs, it isn't possible to open things O_DIRECT,
> which could also be the source of the problem here.

Not really, -snapshot is very clearly the problem here. Note that what's
failing here is not opening the new snapshot but the old temporary image
created by -snapshot.

Kevin

  reply	other threads:[~2011-04-28 14:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-18 14:27 [Qemu-devel] [PATCH v2 0/1] Add QMP bits for blockdev-snapshot-sync Jes.Sorensen
2011-04-18 14:27 ` [Qemu-devel] [PATCH v2 1/1] " Jes.Sorensen
2011-04-27 15:05   ` Luiz Capitulino
2011-04-27 15:05     ` Jes Sorensen
2011-04-28 12:45       ` Jes Sorensen
2011-04-28 13:14     ` Jes Sorensen
2011-04-28 13:21     ` Jes Sorensen
2011-04-28 13:41       ` Kevin Wolf
2011-04-28 13:46         ` Jes Sorensen
2011-04-28 14:42           ` Kevin Wolf [this message]
2011-04-28 14:41             ` Jes Sorensen
2011-04-28 14:21       ` Luiz Capitulino
2011-04-28 14:30         ` Jes Sorensen
2011-04-28 14:38         ` Anthony Liguori
2011-04-28 14:36     ` Anthony Liguori
2011-04-28 14:38       ` Jes Sorensen
2011-04-28 14:46         ` Anthony Liguori
2011-04-28 14:57           ` Jes Sorensen
2011-04-28 15:10             ` Anthony Liguori
2011-04-29 13:38               ` Jes Sorensen
2011-04-29 13:45                 ` Anthony Liguori
2011-05-03 11:44                   ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB97CCC.2010601@redhat.com \
    --to=kwolf@redhat.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.