All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon/f71882fg: Add support for F71808A
Date: Wed, 27 Apr 2011 17:32:07 +0000	[thread overview]
Message-ID: <4DB85317.70201@redhat.com> (raw)
In-Reply-To: <1303393458-4001-2-git-send-email-hdegoede@redhat.com>

Hi

On 04/27/2011 04:17 PM, Jean Delvare wrote:
> Err, wait a minute...
>
> On Thu, 21 Apr 2011 15:44:18 +0200, Hans de Goede wrote:
>> @@ -164,6 +169,7 @@ static const char f71882fg_fan_has_beep[] = {
>>
>>   static const char f71882fg_nr_fans[] = {
>>   	[f71808e]	= 3,
>> +	[f71808a]	= 2, /* +1 fan which is monitor + simple pwm only */
>>   	[f71858fg]	= 3,
>>   	[f71862fg]	= 3,
>>   	[f71869]	= 3,
>
> The values related to the extra fan are never read from the chip, are
> they?

Ugh, good catch, I _cannot_ believe I forgot that, but well I did :)

1 patch fixing this coming up. Feel free to squash it into the
"Add support for F71808A" commit if you prefer not having a git tree
status with this bug in there.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2011-04-27 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-21 13:44 [lm-sensors] [PATCH 2/2] hwmon/f71882fg: Add support for F71808A Hans de Goede
2011-04-27 14:04 ` Jean Delvare
2011-04-27 14:17 ` Jean Delvare
2011-04-27 17:32 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB85317.70201@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.