All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: poky@yoctoproject.org, openembedded-core@lists.openembedded.org
Subject: Re: [poky] [PATCH 1/1] initscripts: remove -i from halt/reboot	arguments and allow override
Date: Thu, 28 Apr 2011 11:57:07 -0700	[thread overview]
Message-ID: <4DB9B883.3050302@linux.intel.com> (raw)
In-Reply-To: <201104281113.45335.paul.eggleton@linux.intel.com>



On 04/28/2011 03:13 AM, Paul Eggleton wrote:
> On Wednesday 27 April 2011 18:56:09 Darren Hart wrote:
>> Is the SED_* tag a common search/replace mechanism in OE recipes? It's
>> fine, I'm just wondering if there is an accepted best practice for this
>> sort of thing. I know we do some sed replacements of /usr/bin and /etc.
> 
> Is there a more appropriate mechanism for substituting values of variables 
> into files (genuinely asking)? If this is the best mechanism it's possible we 
> might want to have a standard naming scheme though, I just made this one up on 
> the spot - I see in some other places we've used FIXMExxxx, so at least it's 
> not the worst :)

There is an effort to document how to do initscripts, so including
something along these lines would be appropriate there. I have no
objection to SED_.... FIXMExxx that's a different story ;-)

> 
> Cheers,
> Paul
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel



WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: poky@yoctoproject.org, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] initscripts: remove -i from halt/reboot	arguments and allow override
Date: Thu, 28 Apr 2011 11:57:07 -0700	[thread overview]
Message-ID: <4DB9B883.3050302@linux.intel.com> (raw)
In-Reply-To: <201104281113.45335.paul.eggleton@linux.intel.com>



On 04/28/2011 03:13 AM, Paul Eggleton wrote:
> On Wednesday 27 April 2011 18:56:09 Darren Hart wrote:
>> Is the SED_* tag a common search/replace mechanism in OE recipes? It's
>> fine, I'm just wondering if there is an accepted best practice for this
>> sort of thing. I know we do some sed replacements of /usr/bin and /etc.
> 
> Is there a more appropriate mechanism for substituting values of variables 
> into files (genuinely asking)? If this is the best mechanism it's possible we 
> might want to have a standard naming scheme though, I just made this one up on 
> the spot - I see in some other places we've used FIXMExxxx, so at least it's 
> not the worst :)

There is an effort to document how to do initscripts, so including
something along these lines would be appropriate there. I have no
objection to SED_.... FIXMExxx that's a different story ;-)

> 
> Cheers,
> Paul
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


  parent reply	other threads:[~2011-04-28 18:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27 16:49 [PATCH 0/1] initscripts: remove -i from halt/reboot arguments and allow override Paul Eggleton
2011-04-27 16:49 ` [PATCH 1/1] " Paul Eggleton
2011-04-27 17:56   ` [poky] " Darren Hart
2011-04-27 17:56     ` Darren Hart
2011-04-28 10:13     ` [poky] " Paul Eggleton
2011-04-28 10:13       ` Paul Eggleton
2011-04-28 11:03       ` [poky] " Koen Kooi
2011-04-28 11:03         ` Koen Kooi
2011-04-28 18:57       ` Darren Hart [this message]
2011-04-28 18:57         ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB9B883.3050302@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.